| Message ID | 20220620051115.3142-2-jasowang@redhat.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Fixing races in probe/remove | expand |
On Mon, Jun 20, 2022 at 01:11:13PM +0800, Jason Wang wrote: > This disabling is a just a hint with best effort, there's no guarantee > that device doesn't send notification. The driver should survive with > that, so let's remove it. > > Signed-off-by: Jason Wang <jasowang@redhat.com> I guess, but frankly this change feels gratituous, and just might uncover latent bugs. Which would be fine if we were out to find and fix them, but given this was compile-tested only, I'm not sure that's the case. > --- > drivers/net/caif/caif_virtio.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/caif/caif_virtio.c b/drivers/net/caif/caif_virtio.c > index 5458f57177a0..c677ded81133 100644 > --- a/drivers/net/caif/caif_virtio.c > +++ b/drivers/net/caif/caif_virtio.c > @@ -705,9 +705,6 @@ static int cfv_probe(struct virtio_device *vdev) > netdev->needed_headroom = cfv->tx_hr; > netdev->needed_tailroom = cfv->tx_tr; > > - /* Disable buffer release interrupts unless we have stopped TX queues */ > - virtqueue_disable_cb(cfv->vq_tx); > - > netdev->mtu = cfv->mtu - cfv->tx_tr; > vdev->priv = cfv; > > -- > 2.25.1
On Mon, Jun 20, 2022 at 5:02 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > On Mon, Jun 20, 2022 at 01:11:13PM +0800, Jason Wang wrote: > > This disabling is a just a hint with best effort, there's no guarantee > > that device doesn't send notification. The driver should survive with > > that, so let's remove it. > > > > Signed-off-by: Jason Wang <jasowang@redhat.com> > > I guess, but frankly this change feels gratituous, and just might > uncover latent bugs. Which would be fine if we were out to > find and fix them, but given this was compile-tested only, > I'm not sure that's the case. Ok, let me drop this from the next version (no way to test). Thanks > > > > --- > > drivers/net/caif/caif_virtio.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/net/caif/caif_virtio.c b/drivers/net/caif/caif_virtio.c > > index 5458f57177a0..c677ded81133 100644 > > --- a/drivers/net/caif/caif_virtio.c > > +++ b/drivers/net/caif/caif_virtio.c > > @@ -705,9 +705,6 @@ static int cfv_probe(struct virtio_device *vdev) > > netdev->needed_headroom = cfv->tx_hr; > > netdev->needed_tailroom = cfv->tx_tr; > > > > - /* Disable buffer release interrupts unless we have stopped TX queues */ > > - virtqueue_disable_cb(cfv->vq_tx); > > - > > netdev->mtu = cfv->mtu - cfv->tx_tr; > > vdev->priv = cfv; > > > > -- > > 2.25.1 >
diff --git a/drivers/net/caif/caif_virtio.c b/drivers/net/caif/caif_virtio.c index 5458f57177a0..c677ded81133 100644 --- a/drivers/net/caif/caif_virtio.c +++ b/drivers/net/caif/caif_virtio.c @@ -705,9 +705,6 @@ static int cfv_probe(struct virtio_device *vdev) netdev->needed_headroom = cfv->tx_hr; netdev->needed_tailroom = cfv->tx_tr; - /* Disable buffer release interrupts unless we have stopped TX queues */ - virtqueue_disable_cb(cfv->vq_tx); - netdev->mtu = cfv->mtu - cfv->tx_tr; vdev->priv = cfv;
This disabling is a just a hint with best effort, there's no guarantee that device doesn't send notification. The driver should survive with that, so let's remove it. Signed-off-by: Jason Wang <jasowang@redhat.com> --- drivers/net/caif/caif_virtio.c | 3 --- 1 file changed, 3 deletions(-)