From patchwork Sun Jun 26 08:23:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuniyuki Iwashima X-Patchwork-Id: 12895645 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6542C433EF for ; Sun, 26 Jun 2022 08:23:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234062AbiFZIXu (ORCPT ); Sun, 26 Jun 2022 04:23:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232734AbiFZIXt (ORCPT ); Sun, 26 Jun 2022 04:23:49 -0400 Received: from smtp-fw-9103.amazon.com (smtp-fw-9103.amazon.com [207.171.188.200]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B315A1B2 for ; Sun, 26 Jun 2022 01:23:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1656231828; x=1687767828; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=urTJ2Oa2gf/XXPJzzfjdCcEZrbbaPHAfAHdZgK1sHjc=; b=GT0OWGg/hMK3hjAv5h3XPS9nuYrIouLmmSLTjrlWtJLDsc1DwS7WE0GC tgCiZhBJwtbaxuZkoz+XUCohopxcerC5TRpbUml6AfBQZzBJ7RezqJXbk wHCm2JyyKByO/UvaA25pkZ/r879PXh2x/A9udZYV4MpviLBk1HOMWIf+T 4=; X-IronPort-AV: E=Sophos;i="5.92,223,1650931200"; d="scan'208";a="1028197668" Received: from pdx4-co-svc-p1-lb2-vlan3.amazon.com (HELO email-inbound-relay-iad-1a-b27d4a00.us-east-1.amazon.com) ([10.25.36.214]) by smtp-border-fw-9103.sea19.amazon.com with ESMTP; 26 Jun 2022 08:23:46 +0000 Received: from EX13MTAUWB001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1a-b27d4a00.us-east-1.amazon.com (Postfix) with ESMTPS id 4269F827E3; Sun, 26 Jun 2022 08:23:43 +0000 (UTC) Received: from EX13D04ANC001.ant.amazon.com (10.43.157.89) by EX13MTAUWB001.ant.amazon.com (10.43.161.207) with Microsoft SMTP Server (TLS) id 15.0.1497.36; Sun, 26 Jun 2022 08:23:43 +0000 Received: from 88665a182662.ant.amazon.com (10.43.161.210) by EX13D04ANC001.ant.amazon.com (10.43.157.89) with Microsoft SMTP Server (TLS) id 15.0.1497.36; Sun, 26 Jun 2022 08:23:40 +0000 From: Kuniyuki Iwashima To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni CC: "Eric W. Biederman" , Pavel Emelyanov , Herbert Xu , "Kuniyuki Iwashima" , Kuniyuki Iwashima , Subject: [PATCH v2 net] af_unix: Do not call kmemdup() for init_net's sysctl table. Date: Sun, 26 Jun 2022 01:23:31 -0700 Message-ID: <20220626082331.36119-1-kuniyu@amazon.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Originating-IP: [10.43.161.210] X-ClientProxiedBy: EX13D40UWA001.ant.amazon.com (10.43.160.53) To EX13D04ANC001.ant.amazon.com (10.43.157.89) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org While setting up init_net's sysctl table, we need not duplicate the global table and can use it directly. Fixes: 1597fbc0faf8 ("[UNIX]: Make the unix sysctl tables per-namespace") Signed-off-by: Kuniyuki Iwashima Acked-by: "Eric W. Biederman" --- v2: * Fix NULL comparison style by checkpatch.pl v1: https://lore.kernel.org/all/20220626074454.28944-1-kuniyu@amazon.com/ --- --- net/unix/sysctl_net_unix.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/net/unix/sysctl_net_unix.c b/net/unix/sysctl_net_unix.c index 01d44e2598e2..4bd856d05135 100644 --- a/net/unix/sysctl_net_unix.c +++ b/net/unix/sysctl_net_unix.c @@ -26,11 +26,16 @@ int __net_init unix_sysctl_register(struct net *net) { struct ctl_table *table; - table = kmemdup(unix_table, sizeof(unix_table), GFP_KERNEL); - if (table == NULL) - goto err_alloc; + if (net_eq(net, &init_net)) { + table = unix_table; + } else { + table = kmemdup(unix_table, sizeof(unix_table), GFP_KERNEL); + if (!table) + goto err_alloc; + + table[0].data = &net->unx.sysctl_max_dgram_qlen; + } - table[0].data = &net->unx.sysctl_max_dgram_qlen; net->unx.ctl = register_net_sysctl(net, "net/unix", table); if (net->unx.ctl == NULL) goto err_reg; @@ -38,7 +43,8 @@ int __net_init unix_sysctl_register(struct net *net) return 0; err_reg: - kfree(table); + if (net_eq(net, &init_net)) + kfree(table); err_alloc: return -ENOMEM; }