| Message ID | 20220628145406.183527-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 74fd304f2395e574a21cd06912f860771c82ee88 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | ipv6: remove redundant store to value after addition | expand |
On 6/28/22 8:54 AM, Colin Ian King wrote: > There is no need to store the result of the addition back to variable count > after the addition. The store is redundant, replace += with just + > > Cleans up clang scan build warning: > warning: Although the value stored to 'count' is used in the enclosing > expression, the value is never actually read from 'count' > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > net/ipv6/route.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: David Ahern <dsahern@kernel.org>
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Tue, 28 Jun 2022 15:54:06 +0100 you wrote: > There is no need to store the result of the addition back to variable count > after the addition. The store is redundant, replace += with just + > > Cleans up clang scan build warning: > warning: Although the value stored to 'count' is used in the enclosing > expression, the value is never actually read from 'count' > > [...] Here is the summary with links: - ipv6: remove redundant store to value after addition https://git.kernel.org/netdev/net-next/c/74fd304f2395 You are awesome, thank you!
diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 0be01a4d48c1..1d6f75eef4bd 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -5934,7 +5934,7 @@ int rt6_dump_route(struct fib6_info *rt, void *p_arg, unsigned int skip) rcu_read_unlock(); if (err) - return count += w.count; + return count + w.count; } return -1;
There is no need to store the result of the addition back to variable count after the addition. The store is redundant, replace += with just + Cleans up clang scan build warning: warning: Although the value stored to 'count' is used in the enclosing expression, the value is never actually read from 'count' Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- net/ipv6/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)