From patchwork Wed Jul 13 15:19:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 12916890 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D990FCCA479 for ; Wed, 13 Jul 2022 15:20:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236884AbiGMPUS (ORCPT ); Wed, 13 Jul 2022 11:20:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236861AbiGMPUP (ORCPT ); Wed, 13 Jul 2022 11:20:15 -0400 Received: from mail-oa1-x31.google.com (mail-oa1-x31.google.com [IPv6:2001:4860:4864:20::31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 606DC45071 for ; Wed, 13 Jul 2022 08:20:14 -0700 (PDT) Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-10c0430e27dso14428725fac.4 for ; Wed, 13 Jul 2022 08:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LKNJ81XHX1rVWPGtQSPsv7xkRycDjY6KgGLmlaN+gNY=; b=UGv5W4X0AgNs0e90Jxbuk8yoqkf1YIvPuG32cxJaOFdhOKMYtLT3UzjNMyJo3NmCSB h/K0iglgBA1TRNjZsaY3WPDnmRX23YpSMViygd9NRIhPlSo9yiPb+fbPadGOwbmeYz9x 0j6tumQO78ZJbjdyG1XX+ZjluB6BIV4JYujzA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LKNJ81XHX1rVWPGtQSPsv7xkRycDjY6KgGLmlaN+gNY=; b=4rAcs4C4rZ3F/sPUblryeMTahmf2bymKPBYXHEZIJPp7FMHamIzyhYXHNqeyQ0c6Cj cuDvikxterySF9TBQ/fdVkARaX/FloOhmPU7dgv7k0BY6IGAeoZdy8qEofCPloL3tJrL PS8Fz6EhHKo25OgwbmL+LIC61BKuxk6fmQS17TEf1HwHz//qzg7xKbyso61/h05dUrF6 VgHyeL6nk6gfgvBLzTN7cC8v2xhPrpejunXkXV/EG4qgcXy9N93HdApLfoypV5HUECEZ vjOMHljkMKfv8OhnROKyD2/jwWLW6g1BINZlAyjb+eGt7mUQsWymnXz0RtBnPne0fLhS Sriw== X-Gm-Message-State: AJIora/9ogkSSdSnaTFQmlWZbNq6sQ1YnmC53hEoOlW/zapT6KtCZm0i ZHoimr3LzXjVITFc9V8hORPzEw== X-Google-Smtp-Source: AGRyM1usHml13CDD+aHqFlxY8s5H+Eng7j9UX5kgdAqCwghIPyT60PRhwo1GRoZ8vA6nrb+/q/6Bdg== X-Received: by 2002:a05:6871:60c:b0:10b:ee7c:2e28 with SMTP id w12-20020a056871060c00b0010bee7c2e28mr4774059oan.21.1657725613728; Wed, 13 Jul 2022 08:20:13 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.pdxnet.pdxeng.ch (host-80-182-13-224.pool80182.interbusiness.it. [80.182.13.224]) by smtp.gmail.com with ESMTPSA id x24-20020a4a3f58000000b00432ac97ad09sm4895477ooe.26.2022.07.13.08.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 08:20:12 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Richard Palethorpe , Jeroen Hofstee , Linux Memory Management List , kernel test robot , lkp@intel.com, lkp@lists.01.org, ltp@lists.linux.it, Dario Binacchi , "David S. Miller" , Eric Dumazet , Greg Kroah-Hartman , Jakub Kicinski , Jiri Slaby , Marc Kleine-Budde , Paolo Abeni , Sebastian Andrzej Siewior , Vincent Mailhol , Wolfgang Grandegger , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] can: slcan: do not sleep with a spin lock held Date: Wed, 13 Jul 2022 17:19:47 +0200 Message-Id: <20220713151947.56379-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org We can't call close_candev() with a spin lock held, so release the lock before calling it. Fixes: c4e54b063f42f ("can: slcan: use CAN network device driver API") Reported-by: kernel test robot Link: https://lore.kernel.org/linux-kernel/Ysrf1Yc5DaRGN1WE@xsang-OptiPlex-9020/ Signed-off-by: Dario Binacchi --- drivers/net/can/slcan/slcan-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/slcan/slcan-core.c b/drivers/net/can/slcan/slcan-core.c index 54d29a410ad5..6aaf2986effc 100644 --- a/drivers/net/can/slcan/slcan-core.c +++ b/drivers/net/can/slcan/slcan-core.c @@ -688,6 +688,7 @@ static int slc_close(struct net_device *dev) /* TTY discipline is running. */ clear_bit(TTY_DO_WRITE_WAKEUP, &sl->tty->flags); } + spin_unlock_bh(&sl->lock); netif_stop_queue(dev); close_candev(dev); sl->can.state = CAN_STATE_STOPPED; @@ -696,7 +697,6 @@ static int slc_close(struct net_device *dev) sl->rcount = 0; sl->xleft = 0; - spin_unlock_bh(&sl->lock); return 0; }