| Message ID | 20220715122402.1017470-1-vee.khee.wong@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | da791bac104a3169b05b54270afe75daacba4641 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,1/1] net: stmmac: remove redunctant disable xPCS EEE call | expand |
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Fri, 15 Jul 2022 20:24:02 +0800 you wrote: > Disable is done in stmmac_init_eee() on the event of MAC link down. > Since setting enable/disable EEE via ethtool will eventually trigger > a MAC down, removing this redunctant call in stmmac_ethtool.c to avoid > calling xpcs_config_eee() twice. > > Fixes: d4aeaed80b0e ("net: stmmac: trigger PCS to turn off on link down") > Signed-off-by: Wong Vee Khee <vee.khee.wong@linux.intel.com> > > [...] Here is the summary with links: - [net,1/1] net: stmmac: remove redunctant disable xPCS EEE call https://git.kernel.org/netdev/net/c/da791bac104a You are awesome, thank you!
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c index abfb3cd5958d..9c3055ee2608 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c @@ -803,14 +803,6 @@ static int stmmac_ethtool_op_set_eee(struct net_device *dev, netdev_warn(priv->dev, "Setting EEE tx-lpi is not supported\n"); - if (priv->hw->xpcs) { - ret = xpcs_config_eee(priv->hw->xpcs, - priv->plat->mult_fact_100ns, - edata->eee_enabled); - if (ret) - return ret; - } - if (!edata->eee_enabled) stmmac_disable_eee_mode(priv);
Disable is done in stmmac_init_eee() on the event of MAC link down. Since setting enable/disable EEE via ethtool will eventually trigger a MAC down, removing this redunctant call in stmmac_ethtool.c to avoid calling xpcs_config_eee() twice. Fixes: d4aeaed80b0e ("net: stmmac: trigger PCS to turn off on link down") Signed-off-by: Wong Vee Khee <vee.khee.wong@linux.intel.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 8 -------- 1 file changed, 8 deletions(-)