From patchwork Sat Jul 16 17:00:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 12920201 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D797C43334 for ; Sat, 16 Jul 2022 17:00:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232358AbiGPRAn (ORCPT ); Sat, 16 Jul 2022 13:00:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232016AbiGPRAf (ORCPT ); Sat, 16 Jul 2022 13:00:35 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A38120185 for ; Sat, 16 Jul 2022 10:00:19 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id b11so14018063eju.10 for ; Sat, 16 Jul 2022 10:00:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fHx3+JjARcVqLchAq3IBsPDCyyKS9HCXdr7RVf+WDMo=; b=mGoolG7fvxZVYt4/cOxod+dCqrOJ8LVz2j/jFt4HPC6fRE4doXmY2PMHp7wEwzmXpF Njm/1kC8mhEmuFQ80OpE+7FDElhEELWtuK8WntfnFda/c27FwckO5ngy2VPCZLzck1lf iyQuAu7VgiTKj1ldNuqE7UbT1Y5/avPsiv4ZQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fHx3+JjARcVqLchAq3IBsPDCyyKS9HCXdr7RVf+WDMo=; b=5DEFHKUVx1T8X/WOokOAD/wEU2RDc6zEmvt7WP6eXmEvHmqvDX3B0LNqIpwMSvtwMx bVXDFnt7mmZrwf6x/hW6wHi3+UGJtT+msUYOObk1zttsLT80jIORBcj1cYALQ8mIV+Wv 1qL8gL1doxsLm3o+aZVDFQeXNVWziUArlpCu6NAt3cqkDZMvLmAkkGTnjLNkgPALnuBT hvcHc3BE51QFuiXMU57rsXCdnxgwAy0DOrCh9UYwjC/y/lAfBtPKRlxpQlAz8X80PADT LZ7DhLknaGx4ys+zmgn3/fb/tluf1ftv09Cn+FzJqvQc4YjHus+AfPhCV4Q7g1i7W71t jaVw== X-Gm-Message-State: AJIora/tjhKPlKOGeqdcU8/vx2nWPqG2KDSUHL814XgwwtxA83qRzFGR yAwvUO4lmqzkcz02Xdwo8mO5BA== X-Google-Smtp-Source: AGRyM1uF88RQH57CRh5vVpqwIC3K2c4oCtDjWaX27PtCv7WQqDeB376TmsjSDwXoYH10UWprZZS6yw== X-Received: by 2002:a17:907:7294:b0:72b:1ae:9c47 with SMTP id dt20-20020a170907729400b0072b01ae9c47mr18608911ejc.253.1657990817736; Sat, 16 Jul 2022 10:00:17 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-80-182-13-224.pool80182.interbusiness.it. [80.182.13.224]) by smtp.gmail.com with ESMTPSA id g3-20020a170906538300b0072b14836087sm3363135ejo.103.2022.07.16.10.00.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Jul 2022 10:00:17 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Jeroen Hofstee , michael@amarulasolutions.com, Amarula patchwork , Dario Binacchi , "David S. Miller" , Eric Dumazet , Greg Kroah-Hartman , Jakub Kicinski , Jiri Slaby , Marc Kleine-Budde , Paolo Abeni , Vincent Mailhol , Wolfgang Grandegger , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [RFC PATCH 4/5] can: slcan: use the generic can_change_mtu() Date: Sat, 16 Jul 2022 19:00:06 +0200 Message-Id: <20220716170007.2020037-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220716170007.2020037-1-dario.binacchi@amarulasolutions.com> References: <20220716170007.2020037-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org X-Patchwork-State: RFC It is useless to define a custom function that does nothing but always return the same error code. Better to use the generic can_change_mtu() function. Signed-off-by: Dario Binacchi --- drivers/net/can/slcan/slcan-core.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/can/slcan/slcan-core.c b/drivers/net/can/slcan/slcan-core.c index 093d232c13dd..7a1540507ecd 100644 --- a/drivers/net/can/slcan/slcan-core.c +++ b/drivers/net/can/slcan/slcan-core.c @@ -727,16 +727,11 @@ static int slcan_netdev_open(struct net_device *dev) return err; } -static int slcan_netdev_change_mtu(struct net_device *dev, int new_mtu) -{ - return -EINVAL; -} - static const struct net_device_ops slcan_netdev_ops = { .ndo_open = slcan_netdev_open, .ndo_stop = slcan_netdev_close, .ndo_start_xmit = slcan_netdev_xmit, - .ndo_change_mtu = slcan_netdev_change_mtu, + .ndo_change_mtu = can_change_mtu, }; /******************************************