| Message ID | 20220716170201.2020510-1-dario.binacchi@amarulasolutions.com (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [RFC] can: can327: remove useless header inclusions | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Series ignored based on subject, async |
On Sat, 16 Jul 2022 19:02:01 +0200 Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote: > -#include <linux/init.h> > #include <linux/module.h> > - > -#include <linux/bitops.h> > -#include <linux/ctype.h> > -#include <linux/errno.h> > -#include <linux/kernel.h> > -#include <linux/list.h> > -#include <linux/lockdep.h> > -#include <linux/netdevice.h> > -#include <linux/skbuff.h> > -#include <linux/spinlock.h> > -#include <linux/string.h> > #include <linux/tty.h> > -#include <linux/tty_ldisc.h> > -#include <linux/workqueue.h> > - > -#include <uapi/linux/tty.h> > - > -#include <linux/can.h> > #include <linux/can/dev.h> > -#include <linux/can/error.h> > #include <linux/can/rx-offload.h> AFAIK, the coding style is to not rely on headers including other headers. Instead, the appropriate header for every symbol used should be included. This is also valid for the similar patch you submitted for slcan. Unless something has changed, this is a NAK from me, sorry. Max
Hi Max, On Sun, Jul 17, 2022 at 11:50 PM Max Staudt <max@enpas.org> wrote: > > On Sat, 16 Jul 2022 19:02:01 +0200 > Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote: > > > -#include <linux/init.h> > > #include <linux/module.h> > > - > > -#include <linux/bitops.h> > > -#include <linux/ctype.h> > > -#include <linux/errno.h> > > -#include <linux/kernel.h> > > -#include <linux/list.h> > > -#include <linux/lockdep.h> > > -#include <linux/netdevice.h> > > -#include <linux/skbuff.h> > > -#include <linux/spinlock.h> > > -#include <linux/string.h> > > #include <linux/tty.h> > > -#include <linux/tty_ldisc.h> > > -#include <linux/workqueue.h> > > - > > -#include <uapi/linux/tty.h> > > - > > -#include <linux/can.h> > > #include <linux/can/dev.h> > > -#include <linux/can/error.h> > > #include <linux/can/rx-offload.h> > > AFAIK, the coding style is to not rely on headers including other > headers. Instead, the appropriate header for every symbol used should > be included. Thanks for the explanation. > > This is also valid for the similar patch you submitted for slcan. Probably something can be removed (if_arp.h, if_ether.h, ...). I will take can327.c as a reference. Thanks and regards, Dario > > > Unless something has changed, this is a NAK from me, sorry. > > > Max
diff --git a/drivers/net/can/can327.c b/drivers/net/can/can327.c index 5da7778d92dc..5b0686f953ed 100644 --- a/drivers/net/can/can327.c +++ b/drivers/net/can/can327.c @@ -12,28 +12,9 @@ #define pr_fmt(fmt) "can327: " fmt -#include <linux/init.h> #include <linux/module.h> - -#include <linux/bitops.h> -#include <linux/ctype.h> -#include <linux/errno.h> -#include <linux/kernel.h> -#include <linux/list.h> -#include <linux/lockdep.h> -#include <linux/netdevice.h> -#include <linux/skbuff.h> -#include <linux/spinlock.h> -#include <linux/string.h> #include <linux/tty.h> -#include <linux/tty_ldisc.h> -#include <linux/workqueue.h> - -#include <uapi/linux/tty.h> - -#include <linux/can.h> #include <linux/can/dev.h> -#include <linux/can/error.h> #include <linux/can/rx-offload.h> #define CAN327_NAPI_WEIGHT 4
Include only the necessary headers. CC: Max Staudt <max@enpas.org> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> --- drivers/net/can/can327.c | 19 ------------------- 1 file changed, 19 deletions(-)