| Message ID | 20220719195325.402745-3-gpiccoli@igalia.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | The panic notifiers refactor strikes back - fixes/clean-ups | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch, async |
On 07/19/22 at 04:53pm, Guilherme G. Piccoli wrote: > Although many notifiers are mentioned in the comments, the panic > notifiers infrastructure is not. Also, the file contains some > trailing whitespaces. Fix both issues here. > > Cc: Arjan van de Ven <arjan@linux.intel.com> > Cc: Cong Wang <xiyou.wangcong@gmail.com> > Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > Cc: Valentin Schneider <valentin.schneider@arm.com> > Cc: Xiaoming Ni <nixiaoming@huawei.com> > Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com> > > --- > > V2: > - no change. > > include/linux/notifier.h | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/include/linux/notifier.h b/include/linux/notifier.h > index aef88c2d1173..d5b01f2e3fcc 100644 > --- a/include/linux/notifier.h > +++ b/include/linux/notifier.h > @@ -208,12 +208,12 @@ static inline int notifier_to_errno(int ret) > > /* > * Declared notifiers so far. I can imagine quite a few more chains > - * over time (eg laptop power reset chains, reboot chain (to clean > + * over time (eg laptop power reset chains, reboot chain (to clean > * device units up), device [un]mount chain, module load/unload chain, > - * low memory chain, screenblank chain (for plug in modular screenblankers) > + * low memory chain, screenblank chain (for plug in modular screenblankers) > * VC switch chains (for loadable kernel svgalib VC switch helpers) etc... > */ > - > + > /* CPU notfiers are defined in include/linux/cpu.h. */ > > /* netdevice notifiers are defined in include/linux/netdevice.h */ > @@ -224,6 +224,8 @@ static inline int notifier_to_errno(int ret) > > /* Virtual Terminal events are defined in include/linux/vt.h. */ > > +/* Panic notifiers are defined in include/linux/panic_notifier.h. */ > + LGTM, Reviewed-by: Baoquan He <bhe@redhat.com> > #define NETLINK_URELEASE 0x0001 /* Unicast netlink socket released */ > > /* Console keyboard events. > -- > 2.37.1 >
diff --git a/include/linux/notifier.h b/include/linux/notifier.h index aef88c2d1173..d5b01f2e3fcc 100644 --- a/include/linux/notifier.h +++ b/include/linux/notifier.h @@ -208,12 +208,12 @@ static inline int notifier_to_errno(int ret) /* * Declared notifiers so far. I can imagine quite a few more chains - * over time (eg laptop power reset chains, reboot chain (to clean + * over time (eg laptop power reset chains, reboot chain (to clean * device units up), device [un]mount chain, module load/unload chain, - * low memory chain, screenblank chain (for plug in modular screenblankers) + * low memory chain, screenblank chain (for plug in modular screenblankers) * VC switch chains (for loadable kernel svgalib VC switch helpers) etc... */ - + /* CPU notfiers are defined in include/linux/cpu.h. */ /* netdevice notifiers are defined in include/linux/netdevice.h */ @@ -224,6 +224,8 @@ static inline int notifier_to_errno(int ret) /* Virtual Terminal events are defined in include/linux/vt.h. */ +/* Panic notifiers are defined in include/linux/panic_notifier.h. */ + #define NETLINK_URELEASE 0x0001 /* Unicast netlink socket released */ /* Console keyboard events.
Although many notifiers are mentioned in the comments, the panic notifiers infrastructure is not. Also, the file contains some trailing whitespaces. Fix both issues here. Cc: Arjan van de Ven <arjan@linux.intel.com> Cc: Cong Wang <xiyou.wangcong@gmail.com> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Cc: Valentin Schneider <valentin.schneider@arm.com> Cc: Xiaoming Ni <nixiaoming@huawei.com> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com> --- V2: - no change. include/linux/notifier.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)