| Message ID | 20220801112444.26175-1-tariqt@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d81c7cdd7a6ddffcc8c00c991e3d6e24db84bd9e |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net/tls: Remove redundant workqueue flush before destroy | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Single patches do not need cover letters |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 7 of 7 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Mon, 1 Aug 2022 14:24:44 +0300 you wrote: > destroy_workqueue() safely destroys the workqueue after draining it. > No need for the explicit call to flush_workqueue(). Remove it. > > Signed-off-by: Tariq Toukan <tariqt@nvidia.com> > --- > net/tls/tls_device.c | 1 - > 1 file changed, 1 deletion(-) Here is the summary with links: - [net-next] net/tls: Remove redundant workqueue flush before destroy https://git.kernel.org/netdev/net-next/c/d81c7cdd7a6d You are awesome, thank you!
diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c index 18c7e5c6d228..e3e6cf75aa03 100644 --- a/net/tls/tls_device.c +++ b/net/tls/tls_device.c @@ -1449,7 +1449,6 @@ int __init tls_device_init(void) void __exit tls_device_cleanup(void) { unregister_netdevice_notifier(&tls_dev_notifier); - flush_workqueue(destruct_wq); destroy_workqueue(destruct_wq); clean_acked_data_flush(); }
destroy_workqueue() safely destroys the workqueue after draining it. No need for the explicit call to flush_workqueue(). Remove it. Signed-off-by: Tariq Toukan <tariqt@nvidia.com> --- net/tls/tls_device.c | 1 - 1 file changed, 1 deletion(-)