| Message ID | 20220804173605.1266574-1-f.fainelli@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bc3410f250219660a7be032c01c954a53b2c26ab |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: bcmgenet: Indicate MAC is in charge of PHY PM | expand |
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Thu, 4 Aug 2022 10:36:04 -0700 you wrote: > Avoid the PHY library call unnecessarily into the suspend/resume functions by > setting phydev->mac_managed_pm to true. The GENET driver essentially does > exactly what mdio_bus_phy_resume() does by calling phy_init_hw() plus > phy_resume(). > > Fixes: fba863b81604 ("net: phy: make PHY PM ops a no-op if MAC driver manages PHY PM") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > > [...] Here is the summary with links: - [net] net: bcmgenet: Indicate MAC is in charge of PHY PM https://git.kernel.org/netdev/net/c/bc3410f25021 You are awesome, thank you!
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index c888ddee1fc4..7ded559842e8 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -393,6 +393,9 @@ int bcmgenet_mii_probe(struct net_device *dev) if (priv->internal_phy && !GENET_IS_V5(priv)) dev->phydev->irq = PHY_MAC_INTERRUPT; + /* Indicate that the MAC is responsible for PHY PM */ + dev->phydev->mac_managed_pm = true; + return 0; }
Avoid the PHY library call unnecessarily into the suspend/resume functions by setting phydev->mac_managed_pm to true. The GENET driver essentially does exactly what mdio_bus_phy_resume() does by calling phy_init_hw() plus phy_resume(). Fixes: fba863b81604 ("net: phy: make PHY PM ops a no-op if MAC driver manages PHY PM") Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- The commit ID used in the Fixes: tag is to ensure that this goes back to when the support for mac_managed_pm was introduced, however in premise this issue has existed for a while, so we might consider a targeted backport all the way back to 4.9. drivers/net/ethernet/broadcom/genet/bcmmii.c | 3 +++ 1 file changed, 3 insertions(+)