| Message ID | 20220811125156.293825-1-mst@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 95bb633048fab742230eb2cdf20b8e2676240a54 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | virtio_net: fix endian-ness for RSS | expand |
Reviewed-by: Andrew Melnychenko andrew@daynix.com On Fri, Aug 12, 2022 at 1:30 PM <patchwork-bot+netdevbpf@kernel.org> wrote: > > Hello: > > This patch was applied to netdev/net.git (master) > by David S. Miller <davem@davemloft.net>: > > On Thu, 11 Aug 2022 08:51:58 -0400 you wrote: > > Using native endian-ness for device supplied fields is wrong > > on BE platforms. Sparse warns about this. > > > > Fixes: 91f41f01d219 ("drivers/net/virtio_net: Added RSS hash report.") > > Cc: "Andrew Melnychenko" <andrew@daynix.com> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > > > [...] > > Here is the summary with links: > - virtio_net: fix endian-ness for RSS > https://git.kernel.org/netdev/net/c/95bb633048fa > > You are awesome, thank you! > -- > Deet-doot-dot, I am a bot. > https://korg.docs.kernel.org/patchwork/pwbot.html > >
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index d9c434b00e9b..6e9868c860bc 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -1208,7 +1208,7 @@ static void virtio_skb_set_hash(const struct virtio_net_hdr_v1_hash *hdr_hash, if (!hdr_hash || !skb) return; - switch ((int)hdr_hash->hash_report) { + switch (__le16_to_cpu(hdr_hash->hash_report)) { case VIRTIO_NET_HASH_REPORT_TCPv4: case VIRTIO_NET_HASH_REPORT_UDPv4: case VIRTIO_NET_HASH_REPORT_TCPv6: @@ -1226,7 +1226,7 @@ static void virtio_skb_set_hash(const struct virtio_net_hdr_v1_hash *hdr_hash, default: rss_hash_type = PKT_HASH_TYPE_NONE; } - skb_set_hash(skb, (unsigned int)hdr_hash->hash_value, rss_hash_type); + skb_set_hash(skb, __le32_to_cpu(hdr_hash->hash_value), rss_hash_type); } static void receive_buf(struct virtnet_info *vi, struct receive_queue *rq,
Using native endian-ness for device supplied fields is wrong on BE platforms. Sparse warns about this. Fixes: 91f41f01d219 ("drivers/net/virtio_net: Added RSS hash report.") Cc: "Andrew Melnychenko" <andrew@daynix.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/net/virtio_net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)