| Message ID | 20220815030848.276746-1-shaozhengchao@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | de64b6b6fb6f369840d171b7c5a9baf31b8b2630 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: sched: fix misuse of qcpu->backlog in gnet_stats_add_queue_cpu | expand |
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Mon, 15 Aug 2022 11:08:48 +0800 you wrote: > In the gnet_stats_add_queue_cpu function, the qstats->qlen statistics > are incorrectly set to qcpu->backlog. > > Fixes: 448e163f8b9b("gen_stats: Add gnet_stats_add_queue()") > Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> > --- > net/core/gen_stats.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net-next] net: sched: fix misuse of qcpu->backlog in gnet_stats_add_queue_cpu https://git.kernel.org/netdev/net/c/de64b6b6fb6f You are awesome, thank you!
diff --git a/net/core/gen_stats.c b/net/core/gen_stats.c index a10335b4ba2d..c8d137ef5980 100644 --- a/net/core/gen_stats.c +++ b/net/core/gen_stats.c @@ -345,7 +345,7 @@ static void gnet_stats_add_queue_cpu(struct gnet_stats_queue *qstats, for_each_possible_cpu(i) { const struct gnet_stats_queue *qcpu = per_cpu_ptr(q, i); - qstats->qlen += qcpu->backlog; + qstats->qlen += qcpu->qlen; qstats->backlog += qcpu->backlog; qstats->drops += qcpu->drops; qstats->requeues += qcpu->requeues;
In the gnet_stats_add_queue_cpu function, the qstats->qlen statistics are incorrectly set to qcpu->backlog. Fixes: 448e163f8b9b("gen_stats: Add gnet_stats_add_queue()") Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> --- net/core/gen_stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)