| Message ID | 20220824024216.4939-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 35bbe652c421037822aba29423f5f1f7d0d69f3f |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: ethernet: ti: davinci_mdio: fix build for mdio bitbang uses | expand |
Hi Randy, On 24/08/22 8:12 am, Randy Dunlap wrote: > davinci_mdio.c uses mdio bitbang APIs, so it should select > MDIO_BITBANG to prevent build errors. > > arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdio_remove': > drivers/net/ethernet/ti/davinci_mdio.c:649: undefined reference to `free_mdio_bitbang' > arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdio_probe': > drivers/net/ethernet/ti/davinci_mdio.c:545: undefined reference to `alloc_mdio_bitbang' > arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdiobb_read': > drivers/net/ethernet/ti/davinci_mdio.c:236: undefined reference to `mdiobb_read' > arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdiobb_write': > drivers/net/ethernet/ti/davinci_mdio.c:253: undefined reference to `mdiobb_write' > > Fixes: d04807b80691 ("net: ethernet: ti: davinci_mdio: Add workaround for errata i2329") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Grygorii Strashko <grygorii.strashko@ti.com> > Cc: Ravi Gunasekaran <r-gunasekaran@ti.com> > Cc: linux-omap@vger.kernel.org > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > Cc: Naresh Kamboju <naresh.kamboju@linaro.org> > Cc: Sudip Mukherjee (Codethink) <sudipm.mukherjee@gmail.com> > --- > drivers/net/ethernet/ti/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- a/drivers/net/ethernet/ti/Kconfig > +++ b/drivers/net/ethernet/ti/Kconfig > @@ -33,6 +33,7 @@ config TI_DAVINCI_MDIO > tristate "TI DaVinci MDIO Support" > depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST > select PHYLIB > + select MDIO_BITBANG > help > This driver supports TI's DaVinci MDIO module. > Thanks for posting this patch before me.
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Tue, 23 Aug 2022 19:42:16 -0700 you wrote: > davinci_mdio.c uses mdio bitbang APIs, so it should select > MDIO_BITBANG to prevent build errors. > > arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdio_remove': > drivers/net/ethernet/ti/davinci_mdio.c:649: undefined reference to `free_mdio_bitbang' > arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdio_probe': > drivers/net/ethernet/ti/davinci_mdio.c:545: undefined reference to `alloc_mdio_bitbang' > arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdiobb_read': > drivers/net/ethernet/ti/davinci_mdio.c:236: undefined reference to `mdiobb_read' > arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdiobb_write': > drivers/net/ethernet/ti/davinci_mdio.c:253: undefined reference to `mdiobb_write' > > [...] Here is the summary with links: - [net-next] net: ethernet: ti: davinci_mdio: fix build for mdio bitbang uses https://git.kernel.org/netdev/net-next/c/35bbe652c421 You are awesome, thank you!
--- a/drivers/net/ethernet/ti/Kconfig +++ b/drivers/net/ethernet/ti/Kconfig @@ -33,6 +33,7 @@ config TI_DAVINCI_MDIO tristate "TI DaVinci MDIO Support" depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST select PHYLIB + select MDIO_BITBANG help This driver supports TI's DaVinci MDIO module.
davinci_mdio.c uses mdio bitbang APIs, so it should select MDIO_BITBANG to prevent build errors. arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdio_remove': drivers/net/ethernet/ti/davinci_mdio.c:649: undefined reference to `free_mdio_bitbang' arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdio_probe': drivers/net/ethernet/ti/davinci_mdio.c:545: undefined reference to `alloc_mdio_bitbang' arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdiobb_read': drivers/net/ethernet/ti/davinci_mdio.c:236: undefined reference to `mdiobb_read' arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdiobb_write': drivers/net/ethernet/ti/davinci_mdio.c:253: undefined reference to `mdiobb_write' Fixes: d04807b80691 ("net: ethernet: ti: davinci_mdio: Add workaround for errata i2329") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Grygorii Strashko <grygorii.strashko@ti.com> Cc: Ravi Gunasekaran <r-gunasekaran@ti.com> Cc: linux-omap@vger.kernel.org Cc: "David S. Miller" <davem@davemloft.net> Cc: Eric Dumazet <edumazet@google.com> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> Cc: Naresh Kamboju <naresh.kamboju@linaro.org> Cc: Sudip Mukherjee (Codethink) <sudipm.mukherjee@gmail.com> --- drivers/net/ethernet/ti/Kconfig | 1 + 1 file changed, 1 insertion(+)