From patchwork Sat Aug 27 04:35:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: shaozhengchao X-Patchwork-Id: 12956783 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E75FAECAAD2 for ; Sat, 27 Aug 2022 04:33:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232315AbiH0EdR (ORCPT ); Sat, 27 Aug 2022 00:33:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbiH0EdQ (ORCPT ); Sat, 27 Aug 2022 00:33:16 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C809AB0B11; Fri, 26 Aug 2022 21:33:12 -0700 (PDT) Received: from dggpeml500026.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MF3dF0BnBzkWKS; Sat, 27 Aug 2022 12:29:37 +0800 (CST) Received: from huawei.com (10.175.101.6) by dggpeml500026.china.huawei.com (7.185.36.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 27 Aug 2022 12:33:10 +0800 From: Zhengchao Shao To: , , , , , , , CC: , , Subject: [PATCH net-next] net: sched: red: remove unused input parameter in red_get_flags() Date: Sat, 27 Aug 2022 12:35:45 +0800 Message-ID: <20220827043545.248535-1-shaozhengchao@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.175.101.6] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500026.china.huawei.com (7.185.36.106) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The input parameter supported_mask is unused in red_get_flags(). Remove it. Signed-off-by: Zhengchao Shao --- include/net/red.h | 1 - net/sched/sch_red.c | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/include/net/red.h b/include/net/red.h index dad41eff8c62..4aed3b2d9725 100644 --- a/include/net/red.h +++ b/include/net/red.h @@ -192,7 +192,6 @@ static inline bool red_check_params(u32 qth_min, u32 qth_max, u8 Wlog, static inline int red_get_flags(unsigned char qopt_flags, unsigned char historic_mask, struct nlattr *flags_attr, - unsigned char supported_mask, struct nla_bitfield32 *p_flags, unsigned char *p_userbits, struct netlink_ext_ack *extack) diff --git a/net/sched/sch_red.c b/net/sched/sch_red.c index cae3b80e4d9d..346c6c41ce56 100644 --- a/net/sched/sch_red.c +++ b/net/sched/sch_red.c @@ -258,8 +258,8 @@ static int __red_change(struct Qdisc *sch, struct nlattr **tb, return -EINVAL; err = red_get_flags(ctl->flags, TC_RED_HISTORIC_FLAGS, - tb[TCA_RED_FLAGS], TC_RED_SUPPORTED_FLAGS, - &flags_bf, &userbits, extack); + tb[TCA_RED_FLAGS], &flags_bf, &userbits, + extack); if (err) return err;