| Message ID | 20220921140524.3831101-4-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c1816b20141597071c67a69e8fb8d31f1b9adfad |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: remove unnecessary set_drvdata() | expand |
On 9/21/22 07:05, Yang Yingliang wrote: > Remove unnecessary dev_set_drvdata() in ->remove(), the driver_data will > be set to NULL in device_unbind_cleanup() after calling ->remove(). > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
diff --git a/drivers/net/dsa/dsa_loop.c b/drivers/net/dsa/dsa_loop.c index 263e41191c29..b9107fe40023 100644 --- a/drivers/net/dsa/dsa_loop.c +++ b/drivers/net/dsa/dsa_loop.c @@ -351,8 +351,6 @@ static void dsa_loop_drv_remove(struct mdio_device *mdiodev) dsa_unregister_switch(ds); dev_put(ps->netdev); - - dev_set_drvdata(&mdiodev->dev, NULL); } static void dsa_loop_drv_shutdown(struct mdio_device *mdiodev)
Remove unnecessary dev_set_drvdata() in ->remove(), the driver_data will be set to NULL in device_unbind_cleanup() after calling ->remove(). Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/dsa/dsa_loop.c | 2 -- 1 file changed, 2 deletions(-)