diff mbox series

[net-next,04/18] net: dsa: hellcreek: remove unnecessary platform_set_drvdata()

Message ID 20220921140524.3831101-5-yangyingliang@huawei.com (mailing list archive)
State Accepted
Commit 8668cfc6db48aafed0cc9cd2f770dea246e02f52
Delegated to: Netdev Maintainers
Headers show
Series net: dsa: remove unnecessary set_drvdata() | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Series has a cover letter
netdev/patch_count fail Series longer than 15 patches (and no cover letter)
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers warning 7 maintainers not CCed: kuba@kernel.org davem@davemloft.net pabeni@redhat.com edumazet@google.com matthias.bgg@gmail.com linux-mediatek@lists.infradead.org linux-arm-kernel@lists.infradead.org
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Yang Yingliang Sept. 21, 2022, 2:05 p.m. UTC 
Remove unnecessary platform_set_drvdata() in ->remove(), the driver_data
will be set to NULL in device_unbind_cleanup() after calling ->remove().

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/net/dsa/hirschmann/hellcreek.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Kurt Kanzenbach Sept. 22, 2022, 6:23 a.m. UTC | #1 
On Wed Sep 21 2022, Yang Yingliang wrote:
> Remove unnecessary platform_set_drvdata() in ->remove(), the driver_data
> will be set to NULL in device_unbind_cleanup() after calling ->remove().
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Acked-by: Kurt Kanzenbach <kurt@linutronix.de>
diff mbox series

Patch

diff --git a/drivers/net/dsa/hirschmann/hellcreek.c b/drivers/net/dsa/hirschmann/hellcreek.c
index ea8bbfce0f1f..eac6ace7c5f9 100644
--- a/drivers/net/dsa/hirschmann/hellcreek.c
+++ b/drivers/net/dsa/hirschmann/hellcreek.c
@@ -1996,7 +1996,6 @@  static int hellcreek_remove(struct platform_device *pdev)
 	hellcreek_hwtstamp_free(hellcreek);
 	hellcreek_ptp_free(hellcreek);
 	dsa_unregister_switch(hellcreek->ds);
-	platform_set_drvdata(pdev, NULL);
 
 	return 0;
 }