@@ -519,7 +519,7 @@ static void can_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
i < bitrate_cnt - 1 ? "%8u, " : "%8u",
bitrate_const[i]);
}
- close_json_array(PRINT_JSON, " ]");
+ close_json_array(PRINT_ANY, " ]");
}
/* data bittiming is irrelevant if fixed bitrate is defined */
@@ -606,7 +606,7 @@ static void can_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
i < dbitrate_cnt - 1 ? "%8u, " : "%8u",
dbitrate_const[i]);
}
- close_json_array(PRINT_JSON, " ]");
+ close_json_array(PRINT_ANY, " ]");
}
if (tb[IFLA_CAN_TERMINATION_CONST] && tb[IFLA_CAN_TERMINATION]) {
@@ -623,7 +623,7 @@ static void can_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
print_hu(PRINT_ANY, NULL,
i < trm_cnt - 1 ? "%hu, " : "%hu",
trm_const[i]);
- close_json_array(PRINT_JSON, " ]");
+ close_json_array(PRINT_ANY, " ]");
}
if (tb[IFLA_CAN_CLOCK]) {
The command "ip --details link show canX" misses the closing bracket `]' of the bitrate, the dbitrate and the termination arrays. The --json output is not impacted. Change the first argument of close_json_array() from PRINT_JSON to PRINT_ANY to fix the problem. The second argument was already set correctly. Fixes: 67f3c7a5cc0d ("iplink_can: use PRINT_ANY to factorize code and fix signedness") Reported-by: Marc Kleine-Budde <mkl@pengutronix.de> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr> --- I just realized that I forgot to adjust the subject prefix to point to iproute2. So here is the v3. Sorry for the noise. ** Changelog ** v2 -> v3 * no change in code. * Set the subject prefix to [PATCH iproute2] instead of [PATCH]. v1 -> v2 * no change in code. * Remove garbage text due to copy/paste mistake in the Reported-by tag of the commit message. * add Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>. --- ip/iplink_can.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)