From patchwork Tue Oct 25 13:59:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aurelien Aptel X-Patchwork-Id: 13019303 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17873C38A2D for ; Tue, 25 Oct 2022 14:04:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232849AbiJYOEv (ORCPT ); Tue, 25 Oct 2022 10:04:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232839AbiJYODv (ORCPT ); Tue, 25 Oct 2022 10:03:51 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2040.outbound.protection.outlook.com [40.107.223.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9D031998BA for ; Tue, 25 Oct 2022 07:01:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RseIdkZDweVGzORM/zl0SVnXj1VXx47n/xIQ732ZpqD3GJ/3asmaWChYWCSrzrF7eIZDC6LOABaRaSq59uzjavOkn+FmS0QUObtVSjDKkQ/KAGUI0X8G0YNio3DuuOulY8o1JVawDw41iSzqxUdwjwqKMvYw9rqRb4xWbdnIHs48VJeBHn4OTLS2IRBtmFWxzWOGuWc2xhJ/aERvmaSK9bLGs/jMKgLx+jSb93ss7c6wpP/1LseQhYYOMtLKwi5DKGPmycNw/D9o9pPcOh/XBY8pE0JVnllBBBi+VXh2CPoL9Y21OEZzdBePvobp+By2lXmY/xmXgfW5rhKQD7ceMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Uzi5joSDMAOMVKgUjEhcUpTyHX6iFpGB6ntvygeSvCY=; b=Cf4418VNoFmtZH5IQe44zzZNEBOwkERIeSLFmVLJ5abp0A8oStXbhbha1+uzn8PBPQhA+iSVSTdZYOcTV60bcsyp4Lgc5DVb9nAJ4QHnoj3Xa1D8H4CwBcDfXrdBFI094/2pz59H3KpeZPfZihE4RJev/r+VXyjjjrkKOqu7mDGufv4nZIuRgMzG8965mg+B8ZwHq/1dNO3kqy2/M5OyuvLGObLgj9oGsVcL5u/T3zwUevxmVfVSLdTqZAH3d3EyJTpkEEvD8jKuam74oCVzhvpYoSyqZxRD2y5OtsDe+4dYM5EvB7m1U3izhE2WMjvS/aAAsV1QPYi+n6FyFi5vNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uzi5joSDMAOMVKgUjEhcUpTyHX6iFpGB6ntvygeSvCY=; b=QJoVhEZ6gaAzieKCANxnu5qT6oI1XwM2bddgP9z9+VYiQwEFen2lIMsP6wGXGXZTdKDIPrUCVLvamFE0o8z1xlCKhb6QEhObVzMBbf3E/9B8vtFfoPlPEHNEjIz5IG70pvkOqOL9ujDFN7GKxGrLJYmaxS/4DJROhApnSKbfujZlwJkeRO3LydMEQ/KsG2312jGHocUxZoxFKAzx2NUobC7L3KOlKdbpIvZlCUdL/8faVrRQVOINfZ0c2bRfqWMndHNwGhgDy34ncFsE6Zz9TTRsKSQqOM+GA0SHxwkKIbUGKHT12tafdWRwBC1hHgaV9lbx7jUlDoo1yknXmIwMYQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from SJ1PR12MB6075.namprd12.prod.outlook.com (2603:10b6:a03:45e::8) by DM4PR12MB5279.namprd12.prod.outlook.com (2603:10b6:5:39f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct 2022 14:01:17 +0000 Received: from SJ1PR12MB6075.namprd12.prod.outlook.com ([fe80::6713:a338:b6aa:871]) by SJ1PR12MB6075.namprd12.prod.outlook.com ([fe80::6713:a338:b6aa:871%3]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022 14:01:17 +0000 From: Aurelien Aptel To: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, tariqt@nvidia.com, leon@kernel.org, linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de, kbusch@kernel.org, axboe@fb.com, chaitanyak@nvidia.com Cc: smalin@nvidia.com, aaptel@nvidia.com, ogerlitz@nvidia.com, yorayz@nvidia.com, borisp@nvidia.com, aurelien.aptel@gmail.com, malin1024@gmail.com Subject: [PATCH v7 12/23] net/mlx5e: Refactor ico sq polling to get budget Date: Tue, 25 Oct 2022 16:59:47 +0300 Message-Id: <20221025135958.6242-13-aaptel@nvidia.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20221025135958.6242-1-aaptel@nvidia.com> References: <20221025135958.6242-1-aaptel@nvidia.com> X-ClientProxiedBy: FR3P281CA0127.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::13) To SJ1PR12MB6075.namprd12.prod.outlook.com (2603:10b6:a03:45e::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PR12MB6075:EE_|DM4PR12MB5279:EE_ X-MS-Office365-Filtering-Correlation-Id: fa7b0d85-cea9-48b6-f399-08dab69162ac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 056JDJLpeTzl5fuAke5MSLNPV2vW+2tLuckKnMclSqd9hnJgbcrxc3rGsOYZL80qEO0PZpmfDJ4QraRhg/oC/nrMZcP7WBAKzTukqzcTWRhkpa/BNsBY5XQtYHyPVrrKktVjbWVv8zgjr++nJy5VOeu+TN2bufyeUQ53zMnVIRyKOYDYG/Rki/tRpHt0xnXC7fhzmtuUyjxUClk8sqZ8PS+2r2dqm0B+yz49OWJrfBLs3hjFHJlClD8SleVwl+Ptk8QPqZ60YiUSAv9t+rvVpHT8yXdq3OE0x5Pzm11SE+EG1XUVxcOKeQmp7v0KZyA+3drJI3TcxdA0wdp2O9ScZnCC8k62rWBSfN1F4YVw5mkX9WRF4BO0nBUCPrX9Vg5oZzcjsK6ND6llgAACgWfgVBKf/tdbp+leYapxe+wBvxvK5qk+JV5+KcJXvOajblli77ip72T//C+5q3Ra+XEFxO6YfEw/MbZyD0I+dqINF1Jkk2j1KJPe3/YQF2F8rigMmV2u4JrkwJpbYiDx/8h1XhV8l8QcR19fgbmANe33K4JolzORZymBrvYl3VJN9ZY6qMOZuo5XS5OMhbt/Bv0Jdnv6Wl4vy4po6Q00yK/jZx+krP2f3d+HvM2zdR8aubYMcgT+ECriGj7dPli65bQfLMv/dmBmlj3SoCELauDbXACUhIKlKY3+SDPCnM0nhS/tWFrOEza/kwvTtPMrZsHqKuW2UwjayCaXfnt2E+vCYXGy8Bn1IuVphzjL9bBKbDj4 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ1PR12MB6075.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(376002)(136003)(39860400002)(346002)(451199015)(478600001)(6636002)(921005)(6666004)(316002)(6486002)(6506007)(2906002)(36756003)(66556008)(4326008)(8676002)(66946007)(66476007)(6512007)(186003)(41300700001)(86362001)(26005)(38100700002)(1076003)(2616005)(83380400001)(8936002)(7416002)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 1PhAnNoL3hF2aCf4gbKakhAU/oX28fGaXQ50WjMR1wacsAWWGTOBfHGVAStMwrvkqxzGHuL0ODwzjKJtU/PjO6kU7+wxyNYWQeVSzZC1yeE/9dLknKM8fKTHTPkNXQBK5WE8CJrkSFlu0qrUK2s/qVkK8v7rfw3ksbbZe52wiLDCjQgmBGL5BHw2rK10fhKYIU5zD2+9tw9lJ4jsYjnrMpPJsUKf/8lFW6glk48WTToQ3FltG42KdwDtn9tcPNmv0yvRQwLGRKck0aX5kLF0sLZD7tPb7kbJPN/Qc4wqJUDOy+MjWBI2V5jh0xp/KQ0b6laDgDAPgNvrUqgpNrBonOO5+LZhewaf1+6xS9TRRu+2dbXwwKKrVNDjdJFiyso18CG1WwOfNgPRl0UpKdEWvop0idK9CKPmvdts4z6tu5rUMlv2M1ocuxhWTxqcxuZT7APgq4UcCYi8Gbc/DdjCDvHL3h1ddt7LjWT9Xk1XbMF3MO179WBBnQIZEGS8oSaqfzZRAiNX4puPquH+tKvuGHVhW9YuUYhIDUxWfrE5vsAYzMQa41BaUB8K0+bJBAQLQGThsmYlD3hhi2zgPaZluuXt7IFW25YR9SUIpsfalp71mZE893v++VVCioQ4P9HZuRYr4afGTbdIMXPP9GXUbuZlBMzAl7qpkdNnqJkMm1Eh79Pq5/FX3Ug3kaLZHjMuywuSQiiFes3A0cA+/fdaBIorJ+HcXPUqeI0PKeJPO95rS0BwZNzP8vx66RX6pav8mGn5HmmKGbZYNyZcibfR2l9WSYECS7bo3xKjMgVqAbtpLWh7q0PqC0UfY3CvZNwHDLVrBtOpO2ot80IXKnMROCdzQOHHinOTP8sLBfAJK1J6TRrafdGTCNBW94fjyqZJtjksOIqrPSSFZzw1r7gdHHPAHYC3ArM+Gk7zeBSQICvEZ1p1xGkmGgNneeTPkH2bxrpOX3njL76DZywDTViQp258JZaPIhW+IyGd4qqlabh7prElEWw5aQ3UrGTrONA6JTvqfBZq28QeA1q16u5s9HX0G8jLjSue0VglJu5YfRbR2rN/9NzaOSYYa2oYKezE7rayyJ7y6gFw0WAocOy6HgdYIHELrjFnQsu6cLiarMUiiHSFpvcoP/MJdv4bJXXNtMCcWHY9pmquhFStAdBXwZjRkJp4xrfxI6/tR5CvVBbvWgMY0tqgxIbAN0l7isEvypXrJJCy8fpXxZ2RTzn3Ak72x6eEKr0HNTorz4rbDve4IYr/Xz1C5PBtZoTHqjQDWE6AF/CbmpomtEgz7nVcxcL+t72SSn6HFPLRXdZwdcvYD2JOgNaK/BojHm9tcTqZVTrNLXYHAefgQp/bFFHNwuBlafLDgyCAz0LQCmSPEvv66bvLmTyM5OYve0xVxQMjhZiG+z4j5gb7QmPWsgO9/zcasry8+bCdYmtT0QYYoDptTJz7U1IZcWK5DyvV2E6ZMgHTF/VoQAUDclPyE0xtRvL9Jfo2K33wgnOyfFQqHqp/GmfhJl2TJtPpy14D6wcSqy7yFB59zk2mijFb+MaVU59kuQFcarXi1yDJdVybcQOEyf4GMwML4yFN5OrlbeV3 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa7b0d85-cea9-48b6-f399-08dab69162ac X-MS-Exchange-CrossTenant-AuthSource: SJ1PR12MB6075.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 14:01:16.9923 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kSEdXGhkRBEBBV8V7bHYXXM59R6+jWZ506n33jj6nL5Sgwu7/eZ1/dNZym5iYYHF57ORDRiiHLPFzcouihBhNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5279 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Or Gerlitz The mlx5e driver uses ICO SQs for internal control operations which are not visible to the network stack, such as UMR mapping for striding RQ (MPWQ) and etc more cases. The upcoming nvmeotcp offload uses ico sq for umr mapping as part of the offload. As a pre-step for nvmeotcp ico sqs which have their own napi and need to comply with budget, add the budget as parameter to the polling of cqs related to ico sqs. The polling already stops after a limit is reached, so just have the caller to provide this limit as the budget. No functional change here. Signed-off-by: Or Gerlitz Signed-off-by: Aurelien Aptel Reviewed-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 4 ++-- drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h b/drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h index 4456ad5cedf1..30c456bfc1c8 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h @@ -41,7 +41,7 @@ void mlx5e_trigger_irq(struct mlx5e_icosq *sq); void mlx5e_completion_event(struct mlx5_core_cq *mcq, struct mlx5_eqe *eqe); void mlx5e_cq_error_event(struct mlx5_core_cq *mcq, enum mlx5_event event); int mlx5e_napi_poll(struct napi_struct *napi, int budget); -int mlx5e_poll_ico_cq(struct mlx5e_cq *cq); +int mlx5e_poll_ico_cq(struct mlx5e_cq *cq, int budget); /* RX */ void mlx5e_page_dma_unmap(struct mlx5e_rq *rq, struct page *page); diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c index 58084650151f..261802579791 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c @@ -853,7 +853,7 @@ static void mlx5e_handle_shampo_hd_umr(struct mlx5e_shampo_umr umr, shampo->ci = (shampo->ci + umr.len) & (shampo->hd_per_wq - 1); } -int mlx5e_poll_ico_cq(struct mlx5e_cq *cq) +int mlx5e_poll_ico_cq(struct mlx5e_cq *cq, int budget) { struct mlx5e_icosq *sq = container_of(cq, struct mlx5e_icosq, cq); struct mlx5_cqe64 *cqe; @@ -928,7 +928,7 @@ int mlx5e_poll_ico_cq(struct mlx5e_cq *cq) wi->wqe_type); } } while (!last_wqe); - } while ((++i < MLX5E_TX_CQ_POLL_BUDGET) && (cqe = mlx5_cqwq_get_cqe(&cq->wq))); + } while ((++i < budget) && (cqe = mlx5_cqwq_get_cqe(&cq->wq))); sq->cc = sqcc; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c index 9a458a5d9853..9ddacb5e1bf4 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c @@ -176,8 +176,8 @@ int mlx5e_napi_poll(struct napi_struct *napi, int budget) busy |= work_done == budget; } - mlx5e_poll_ico_cq(&c->icosq.cq); - if (mlx5e_poll_ico_cq(&c->async_icosq.cq)) + mlx5e_poll_ico_cq(&c->icosq.cq, MLX5E_TX_CQ_POLL_BUDGET); + if (mlx5e_poll_ico_cq(&c->async_icosq.cq, MLX5E_TX_CQ_POLL_BUDGET)) /* Don't clear the flag if nothing was polled to prevent * queueing more WQEs and overflowing the async ICOSQ. */