| Message ID | 20221028073457.3492371-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 47aeed9d2ccde99c990ba3163b8d8308ad00df1b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: hns: hnae: remove unnecessary __module_get() and module_put() | expand |
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Fri, 28 Oct 2022 15:34:57 +0800 you wrote: > hnae_ae_register() is called from hns_dsaf_probe(), the refcount of > module hnae has already be got in resolve_symbol() while calling the > function, so the __module_get()/module_put() can be removed. > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/net/ethernet/hisilicon/hns/hnae.c | 3 --- > 1 file changed, 3 deletions(-) Here is the summary with links: - [net-next] net: hns: hnae: remove unnecessary __module_get() and module_put() https://git.kernel.org/netdev/net-next/c/47aeed9d2ccd You are awesome, thank you!
diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.c b/drivers/net/ethernet/hisilicon/hns/hnae.c index 430eccea8e5e..9b26f0f2c748 100644 --- a/drivers/net/ethernet/hisilicon/hns/hnae.c +++ b/drivers/net/ethernet/hisilicon/hns/hnae.c @@ -424,8 +424,6 @@ int hnae_ae_register(struct hnae_ae_dev *hdev, struct module *owner) return ret; } - __module_get(THIS_MODULE); - INIT_LIST_HEAD(&hdev->handle_list); spin_lock_init(&hdev->lock); @@ -445,7 +443,6 @@ EXPORT_SYMBOL(hnae_ae_register); void hnae_ae_unregister(struct hnae_ae_dev *hdev) { device_unregister(&hdev->cls_dev); - module_put(THIS_MODULE); } EXPORT_SYMBOL(hnae_ae_unregister);
hnae_ae_register() is called from hns_dsaf_probe(), the refcount of module hnae has already be got in resolve_symbol() while calling the function, so the __module_get()/module_put() can be removed. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hnae.c | 3 --- 1 file changed, 3 deletions(-)