| Message ID | 20221104204837.614459-1-roman.gushchin@linux.dev (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 14ef5c39891ede40e40797f7e9da845896c86670 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: macb: implement live mac addr change | expand |
On Fri, Nov 04, 2022 at 01:48:37PM -0700, Roman Gushchin wrote: > Implement live mac addr change for the macb ethernet driver. > > Signed-off-by: Roman Gushchin <roman.gushchin@linux.dev> > --- > drivers/net/ethernet/cadence/macb_main.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Fri, 4 Nov 2022 13:48:37 -0700 you wrote: > Implement live mac addr change for the macb ethernet driver. > > Signed-off-by: Roman Gushchin <roman.gushchin@linux.dev> > --- > drivers/net/ethernet/cadence/macb_main.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) Here is the summary with links: - [net-next] net: macb: implement live mac addr change https://git.kernel.org/netdev/net-next/c/14ef5c39891e You are awesome, thank you!
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 4f63f1ba3161..991d5041c836 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -2947,6 +2947,18 @@ static int macb_change_mtu(struct net_device *dev, int new_mtu) return 0; } +static int macb_set_mac_addr(struct net_device *dev, void *addr) +{ + int err; + + err = eth_mac_addr(dev, addr); + if (err < 0) + return err; + + macb_set_hwaddr(netdev_priv(dev)); + return 0; +} + static void gem_update_stats(struct macb *bp) { struct macb_queue *queue; @@ -3786,7 +3798,7 @@ static const struct net_device_ops macb_netdev_ops = { .ndo_eth_ioctl = macb_ioctl, .ndo_validate_addr = eth_validate_addr, .ndo_change_mtu = macb_change_mtu, - .ndo_set_mac_address = eth_mac_addr, + .ndo_set_mac_address = macb_set_mac_addr, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = macb_poll_controller, #endif @@ -4049,6 +4061,8 @@ static int macb_init(struct platform_device *pdev) dev->ethtool_ops = &macb_ethtool_ops; } + dev->priv_flags |= IFF_LIVE_ADDR_CHANGE; + /* Set features */ dev->hw_features = NETIF_F_SG;
Implement live mac addr change for the macb ethernet driver. Signed-off-by: Roman Gushchin <roman.gushchin@linux.dev> --- drivers/net/ethernet/cadence/macb_main.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-)