| Message ID | 20221107012159.211387-1-shaozhengchao@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b0c09c7f08c2467b2089bdf4adb2fbbc2464f4a8 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: ethernet: mtk-star-emac: disable napi when connect and start PHY failed in mtk_star_enable() | expand |
On Mon, Nov 07, 2022 at 09:21:59AM +0800, Zhengchao Shao wrote: > When failed to connect to and start PHY in mtk_star_enable() for opening > device, napi isn't disabled. When open mtk star device next time, it will > reports a invalid opcode issue. Fix it. Only be compiled, not be tested. > > Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver") > Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> > --- > drivers/net/ethernet/mediatek/mtk_star_emac.c | 2 ++ > 1 file changed, 2 insertions(+) > Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Hello: This patch was applied to netdev/net.git (master) by Paolo Abeni <pabeni@redhat.com>: On Mon, 7 Nov 2022 09:21:59 +0800 you wrote: > When failed to connect to and start PHY in mtk_star_enable() for opening > device, napi isn't disabled. When open mtk star device next time, it will > reports a invalid opcode issue. Fix it. Only be compiled, not be tested. > > Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver") > Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> > > [...] Here is the summary with links: - [net] net: ethernet: mtk-star-emac: disable napi when connect and start PHY failed in mtk_star_enable() https://git.kernel.org/netdev/net/c/b0c09c7f08c2 You are awesome, thank you!
diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c index 7e890f81148e..7050351250b7 100644 --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c @@ -1026,6 +1026,8 @@ static int mtk_star_enable(struct net_device *ndev) return 0; err_free_irq: + napi_disable(&priv->rx_napi); + napi_disable(&priv->tx_napi); free_irq(ndev->irq, ndev); err_free_skbs: mtk_star_free_rx_skbs(priv);
When failed to connect to and start PHY in mtk_star_enable() for opening device, napi isn't disabled. When open mtk star device next time, it will reports a invalid opcode issue. Fix it. Only be compiled, not be tested. Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver") Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> --- drivers/net/ethernet/mediatek/mtk_star_emac.c | 2 ++ 1 file changed, 2 insertions(+)