| Message ID | 20221107093423.50810-1-shaozhengchao@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: cxgb3_main: disable napi when bind qsets failed in cxgb_up() | expand |
On Mon, Nov 07, 2022 at 05:34:23PM +0800, Zhengchao Shao wrote: > When failed to bind qsets in cxgb_up() for opening device, napi isn't > disabled. When open cxgb3 device next time, it will reports a invalid > opcode issue. Fix it. Only be compiled, not be tested. > > Fixes: f7917c009c28 ("chelsio: Move the Chelsio drivers") > Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> > --- > drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 1 + > 1 file changed, 1 insertion(+) > Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c index a52e6b6e2876..9b84c8d8d309 100644 --- a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c +++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c @@ -1301,6 +1301,7 @@ static int cxgb_up(struct adapter *adap) if (ret < 0) { CH_ERR(adap, "failed to bind qsets, err %d\n", ret); t3_intr_disable(adap); + quiesce_rx(adap); free_irq_resources(adap); err = ret; goto out;
When failed to bind qsets in cxgb_up() for opening device, napi isn't disabled. When open cxgb3 device next time, it will reports a invalid opcode issue. Fix it. Only be compiled, not be tested. Fixes: f7917c009c28 ("chelsio: Move the Chelsio drivers") Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> --- drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 1 + 1 file changed, 1 insertion(+)