| Message ID | 20221108153459.811293-2-atenart@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1b16b3fdf675cca15a537572bac50cc5354368fc |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | macsec: clear encryption keys in h/w drivers | expand |
diff --git a/drivers/net/phy/mscc/mscc_macsec.c b/drivers/net/phy/mscc/mscc_macsec.c index ee5b17edca39..f81b077618f4 100644 --- a/drivers/net/phy/mscc/mscc_macsec.c +++ b/drivers/net/phy/mscc/mscc_macsec.c @@ -632,6 +632,7 @@ static void vsc8584_macsec_free_flow(struct vsc8531_private *priv, list_del(&flow->list); clear_bit(flow->index, bitmap); + memzero_explicit(flow->key, sizeof(flow->key)); kfree(flow); }
Commit aaab73f8fba4 ("macsec: clear encryption keys from the stack after setting up offload") made sure to clean encryption keys from the stack after setting up offloading, but the MSCC PHY driver made a copy, kept it in the flow data and did not clear it when freeing a flow. Fix this. Fixes: 28c5107aa904 ("net: phy: mscc: macsec support") Signed-off-by: Antoine Tenart <atenart@kernel.org> --- drivers/net/phy/mscc/mscc_macsec.c | 1 + 1 file changed, 1 insertion(+)