| Message ID | 20221117162101.1467069-1-dvyukov@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d9e8da558580513318a36f4ecb1b6e28e41b4de0 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v2] NFC: nci: Extend virtual NCI deinit test | expand |
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Thu, 17 Nov 2022 17:21:01 +0100 you wrote: > Extend the test to check the scenario when NCI core tries to send data > to already closed device to ensure that nothing bad happens. > > Signed-off-by: Dmitry Vyukov <dvyukov@google.com> > Cc: Bongsu Jeon <bongsu.jeon@samsung.com> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: netdev@vger.kernel.org > > [...] Here is the summary with links: - [net-next,v2] NFC: nci: Extend virtual NCI deinit test https://git.kernel.org/netdev/net-next/c/d9e8da558580 You are awesome, thank you!
diff --git a/tools/testing/selftests/nci/nci_dev.c b/tools/testing/selftests/nci/nci_dev.c index 162c41e9bcae8..1562aa7d60b0f 100644 --- a/tools/testing/selftests/nci/nci_dev.c +++ b/tools/testing/selftests/nci/nci_dev.c @@ -888,6 +888,17 @@ TEST_F(NCI, deinit) &msg); ASSERT_EQ(rc, 0); EXPECT_EQ(get_dev_enable_state(&msg), 0); + + /* Test that operations that normally send packets to the driver + * don't cause issues when the device is already closed. + * Note: the send of NFC_CMD_DEV_UP itself still succeeds it's just + * that the device won't actually be up. + */ + close(self->virtual_nci_fd); + self->virtual_nci_fd = -1; + rc = send_cmd_with_idx(self->sd, self->fid, self->pid, + NFC_CMD_DEV_UP, self->dev_idex); + EXPECT_EQ(rc, 0); } TEST_HARNESS_MAIN
Extend the test to check the scenario when NCI core tries to send data to already closed device to ensure that nothing bad happens. Signed-off-by: Dmitry Vyukov <dvyukov@google.com> Cc: Bongsu Jeon <bongsu.jeon@samsung.com> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: Jakub Kicinski <kuba@kernel.org> Cc: netdev@vger.kernel.org --- Changes in v2: - use C multi-line comment style instead of C++ style --- tools/testing/selftests/nci/nci_dev.c | 11 +++++++++++ 1 file changed, 11 insertions(+) base-commit: f12ed9c04804eec4f1819097a0fd0b4800adac2f prerequisite-patch-id: 214c5357c652cee65ee803d0f45f4b15cfcc9861