| Message ID | 20221223170345.3785809-1-hauke@hauke-m.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 22c877d93eedccebcf0260ce8c37b9b1f908a76f |
| Delegated to: | Stephen Hemminger |
| Headers | show |
| Series | [iproute2,v2] configure: Remove include <sys/stat.h> | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
Hello: This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <stephen@networkplumber.org>: On Fri, 23 Dec 2022 18:03:45 +0100 you wrote: > The check_name_to_handle_at() function in the configure script is > including sys/stat.h. This include fails with glibc 2.36 like this: > ```` > In file included from /linux-5.15.84/include/uapi/linux/stat.h:5, > from /toolchain-x86_64_gcc-12.2.0_glibc/include/bits/statx.h:31, > from /toolchain-x86_64_gcc-12.2.0_glibc/include/sys/stat.h:465, > from config.YExfMc/name_to_handle_at_test.c:3: > /linux-5.15.84/include/uapi/linux/types.h:10:2: warning: #warning "Attempt to use kernel headers from user space, see https://kernelnewbies.org/KernelHeaders" [-Wcpp] > 10 | #warning "Attempt to use kernel headers from user space, see https://kernelnewbies.org/KernelHeaders" > | ^~~~~~~ > In file included from /linux-5.15.84/include/uapi/linux/posix_types.h:5, > from /linux-5.15.84/include/uapi/linux/types.h:14: > /linux-5.15.84/include/uapi/linux/stddef.h:5:10: fatal error: linux/compiler_types.h: No such file or directory > 5 | #include <linux/compiler_types.h> > | ^~~~~~~~~~~~~~~~~~~~~~~~ > compilation terminated. > ```` > > [...] Here is the summary with links: - [iproute2,v2] configure: Remove include <sys/stat.h> https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=22c877d93eed You are awesome, thank you!
diff --git a/configure b/configure index c02753bb..18be5a03 100755 --- a/configure +++ b/configure @@ -214,7 +214,6 @@ check_name_to_handle_at() cat >$TMPDIR/name_to_handle_at_test.c <<EOF #define _GNU_SOURCE #include <sys/types.h> -#include <sys/stat.h> #include <fcntl.h> int main(int argc, char **argv) {
The check_name_to_handle_at() function in the configure script is including sys/stat.h. This include fails with glibc 2.36 like this: ```` In file included from /linux-5.15.84/include/uapi/linux/stat.h:5, from /toolchain-x86_64_gcc-12.2.0_glibc/include/bits/statx.h:31, from /toolchain-x86_64_gcc-12.2.0_glibc/include/sys/stat.h:465, from config.YExfMc/name_to_handle_at_test.c:3: /linux-5.15.84/include/uapi/linux/types.h:10:2: warning: #warning "Attempt to use kernel headers from user space, see https://kernelnewbies.org/KernelHeaders" [-Wcpp] 10 | #warning "Attempt to use kernel headers from user space, see https://kernelnewbies.org/KernelHeaders" | ^~~~~~~ In file included from /linux-5.15.84/include/uapi/linux/posix_types.h:5, from /linux-5.15.84/include/uapi/linux/types.h:14: /linux-5.15.84/include/uapi/linux/stddef.h:5:10: fatal error: linux/compiler_types.h: No such file or directory 5 | #include <linux/compiler_types.h> | ^~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. ```` Just removing the include works, the manpage of name_to_handle_at() says only fcntl.h is needed. Fixes: c5b72cc56bf8 ("lib/fs: fix issue when {name,open}_to_handle_at() is not implemented") Tested-by: Heiko Thiery <heiko.thiery@gmail.com> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> --- configure | 1 - 1 file changed, 1 deletion(-)