| Message ID | 20230125213817.1424447-2-iii@linux.ibm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | BPF |
| Headers | show |
| Series | Support bpf trampoline for s390x | expand |
On Wed, Jan 25, 2023 at 1:39 PM Ilya Leoshkevich <iii@linux.ibm.com> wrote: > > When building with O=, the following linker error occurs: > > clang: error: no such file or directory: 'liburandom_read.so' > > Fix by adding $(OUTPUT) to the linker search path. > > Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com> > --- > tools/testing/selftests/bpf/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile > index c9b5ed59e1ed..43098eb15d31 100644 > --- a/tools/testing/selftests/bpf/Makefile > +++ b/tools/testing/selftests/bpf/Makefile > @@ -189,9 +189,9 @@ $(OUTPUT)/liburandom_read.so: urandom_read_lib1.c urandom_read_lib2.c > $(OUTPUT)/urandom_read: urandom_read.c urandom_read_aux.c $(OUTPUT)/liburandom_read.so > $(call msg,BINARY,,$@) > $(Q)$(CLANG) $(filter-out -static,$(CFLAGS) $(LDFLAGS)) $(filter %.c,$^) \ > - liburandom_read.so $(filter-out -static,$(LDLIBS)) \ > + $(filter-out -static,$(LDLIBS)) \ > -fuse-ld=$(LLD) -Wl,-znoseparate-code -Wl,--build-id=sha1 \ > - -Wl,-rpath=. -o $@ > + -Wl,-rpath=. -o $@ -lurandom_read -L$(OUTPUT) why moving to the end? it's nice in verbose logs when the last thing is the resulting file ($@), so if possible, let's move it back? > > $(OUTPUT)/sign-file: ../../../../scripts/sign-file.c > $(call msg,SIGN-FILE,,$@) > -- > 2.39.1 >
On Wed, 2023-01-25 at 17:07 -0800, Andrii Nakryiko wrote: > On Wed, Jan 25, 2023 at 1:39 PM Ilya Leoshkevich <iii@linux.ibm.com> > wrote: > > > > When building with O=, the following linker error occurs: > > > > clang: error: no such file or directory: 'liburandom_read.so' > > > > Fix by adding $(OUTPUT) to the linker search path. > > > > Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com> > > --- > > tools/testing/selftests/bpf/Makefile | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tools/testing/selftests/bpf/Makefile > > b/tools/testing/selftests/bpf/Makefile > > index c9b5ed59e1ed..43098eb15d31 100644 > > --- a/tools/testing/selftests/bpf/Makefile > > +++ b/tools/testing/selftests/bpf/Makefile > > @@ -189,9 +189,9 @@ $(OUTPUT)/liburandom_read.so: > > urandom_read_lib1.c urandom_read_lib2.c > > $(OUTPUT)/urandom_read: urandom_read.c urandom_read_aux.c > > $(OUTPUT)/liburandom_read.so > > $(call msg,BINARY,,$@) > > $(Q)$(CLANG) $(filter-out -static,$(CFLAGS) $(LDFLAGS)) > > $(filter %.c,$^) \ > > - liburandom_read.so $(filter-out - > > static,$(LDLIBS)) \ > > + $(filter-out - > > static,$(LDLIBS)) \ > > -fuse-ld=$(LLD) -Wl,-znoseparate-code -Wl,-- > > build-id=sha1 \ > > - -Wl,-rpath=. -o $@ > > + -Wl,-rpath=. -o $@ -lurandom_read -L$(OUTPUT) > > why moving to the end? it's nice in verbose logs when the last thing > is the resulting file ($@), so if possible, let's move it back? You're right, I'm just used to having the libraries at the end, but here we already have $(LDLIBS) in the middle. Will do in v2. > > > > > $(OUTPUT)/sign-file: ../../../../scripts/sign-file.c > > $(call msg,SIGN-FILE,,$@) > > -- > > 2.39.1 > >
diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile index c9b5ed59e1ed..43098eb15d31 100644 --- a/tools/testing/selftests/bpf/Makefile +++ b/tools/testing/selftests/bpf/Makefile @@ -189,9 +189,9 @@ $(OUTPUT)/liburandom_read.so: urandom_read_lib1.c urandom_read_lib2.c $(OUTPUT)/urandom_read: urandom_read.c urandom_read_aux.c $(OUTPUT)/liburandom_read.so $(call msg,BINARY,,$@) $(Q)$(CLANG) $(filter-out -static,$(CFLAGS) $(LDFLAGS)) $(filter %.c,$^) \ - liburandom_read.so $(filter-out -static,$(LDLIBS)) \ + $(filter-out -static,$(LDLIBS)) \ -fuse-ld=$(LLD) -Wl,-znoseparate-code -Wl,--build-id=sha1 \ - -Wl,-rpath=. -o $@ + -Wl,-rpath=. -o $@ -lurandom_read -L$(OUTPUT) $(OUTPUT)/sign-file: ../../../../scripts/sign-file.c $(call msg,SIGN-FILE,,$@)
When building with O=, the following linker error occurs: clang: error: no such file or directory: 'liburandom_read.so' Fix by adding $(OUTPUT) to the linker search path. Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com> --- tools/testing/selftests/bpf/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)