| Message ID | 20230207102501.11418-1-linux@fw-web.de (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | dt-bindings: mt76: add active-low property to led | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
> Gesendet: Dienstag, 07. Februar 2023 um 11:40 Uhr > Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org> > On 07/02/2023 11:25, Frank Wunderlich wrote: > > From: Frank Wunderlich <frank-w@public-files.de> > > > > LEDs can be in low-active mode, so add dt property for it. > > > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > > --- > > .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml > > index f0c78f994491..212508672979 100644 > > --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml > > +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml > > @@ -112,6 +112,11 @@ properties: > > $ref: /schemas/leds/common.yaml# > > additionalProperties: false > > properties: > > + led-active-low: > > + description: > > + LED is enabled with ground signal. > > What does it mean? You set voltage of regulator to 0? Or you set GPIO as > 0? If the latter, it's not the property of LED... basicly it is a gpio-led mapped into the mt76 driver, but not passing gpio itself in this property (like gpio-led does). This gpio is set to 0 signal (gnd) to let the led go on ;) so imho it is a led-property, but below the wifi-node as the trigger comes from mt76 hardware, not an external (soc) gpio controller. mt76 driver supports it already like i post change here: https://patchwork.kernel.org/project/linux-mediatek/patch/20230205174833.107050-1-linux@fw-web.de/ only needed the binding for it. > Best regards, > Krzysztof > >
On 07/02/2023 13:12, Frank Wunderlich wrote: >> Gesendet: Dienstag, 07. Februar 2023 um 11:40 Uhr >> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org> >> On 07/02/2023 11:25, Frank Wunderlich wrote: >>> From: Frank Wunderlich <frank-w@public-files.de> >>> >>> LEDs can be in low-active mode, so add dt property for it. >>> >>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de> >>> --- >>> .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml >>> index f0c78f994491..212508672979 100644 >>> --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml >>> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml >>> @@ -112,6 +112,11 @@ properties: >>> $ref: /schemas/leds/common.yaml# >>> additionalProperties: false >>> properties: >>> + led-active-low: >>> + description: >>> + LED is enabled with ground signal. >> >> What does it mean? You set voltage of regulator to 0? Or you set GPIO as >> 0? If the latter, it's not the property of LED... > > basicly it is a gpio-led mapped into the mt76 driver, but not passing gpio itself in this property (like gpio-led does). > This gpio is set to 0 signal (gnd) to let the led go on ;) so imho it is a led-property, but below the wifi-node as > the trigger comes from mt76 hardware, not an external (soc) gpio controller. > > mt76 driver supports it already like i post change here: > If the driver supports it already and it was never documented, please state it. Your commit says you add a new property. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml index f0c78f994491..212508672979 100644 --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml @@ -112,6 +112,11 @@ properties: $ref: /schemas/leds/common.yaml# additionalProperties: false properties: + led-active-low: + description: + LED is enabled with ground signal. + type: boolean + led-sources: maxItems: 1