| Message ID | 20230207171512.35425-1-linux@fw-web.de (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | dt-bindings: mt76: allow up to 4 interrupts for mt7986 | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Tue, Feb 07, 2023 at 06:15:12PM +0100, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > Mt7986 needs 4 interrupts which are already defined in mt7986a.dtsi. > Update binding to reflect it > > This fixes this error in dtbs_check (here only bpi-r3 example): > > arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: wifi@18000000: > interrupts: [[0, 213, 4], [0, 214, 4], [0, 215, 4], [0, 216, 4]] is too long > From schema: Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml > arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: wifi@18000000: > Unevaluated properties are not allowed ('interrupts' was unexpected) > From schema: Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > --- > .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml > index 212508672979..222b657fe4ea 100644 > --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml > +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml > @@ -38,7 +38,10 @@ properties: > MT7986 should contain 3 regions consys, dcm, and sku, in this order. > > interrupts: > - maxItems: 1 > + minItems: 1 > + maxItems: 4 > + description: > + MT7986 should contain 4 items. The schema and the description don't match. You need to define what each interrupt is. Rob
diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml index 212508672979..222b657fe4ea 100644 --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml @@ -38,7 +38,10 @@ properties: MT7986 should contain 3 regions consys, dcm, and sku, in this order. interrupts: - maxItems: 1 + minItems: 1 + maxItems: 4 + description: + MT7986 should contain 4 items. power-domains: maxItems: 1