From patchwork Wed Feb 8 13:31:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13133037 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90649C05027 for ; Wed, 8 Feb 2023 13:31:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230468AbjBHNbq (ORCPT ); Wed, 8 Feb 2023 08:31:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230010AbjBHNbj (ORCPT ); Wed, 8 Feb 2023 08:31:39 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1E4247EFB; Wed, 8 Feb 2023 05:31:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675863098; x=1707399098; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=EQiB8u8MT9RmdXrZcW6jRKDu65zFVwKhnZXefFKcEvo=; b=j8CS3nR3fOCXtseyIhe/YFbsZVbY4uitXi3WX29ZAMVyiEvY6Uz5IdI4 +g8eO97Ax/niSD/D0tluV4I6ncMbYvxoOFlx/ESXfqCBvsdgGPNXac2dE 8gO1lnFZX/RuDGrwt0XkQV0WI4lb0nG6NyBnFjo3J4ZYx04ODxXO7K49Z oU+Q0Vc1+BzsM1b0JhWu7zjhiWYPzaAGd47O9wVPKbbefAG6eTqtWm7Ml RQ8XmJbJQt/Cr9OpZrz5ZlQ4YIuoVYmfwjdLYR+Bh30aPKsheAm7u7kBG T+XYX1WtQm46/PlAAncIPlbBmj7VYAIXz7nCB43iFWO7i2E35AG/BlcCU w==; X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="416017505" X-IronPort-AV: E=Sophos;i="5.97,280,1669104000"; d="scan'208";a="416017505" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2023 05:31:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="617215419" X-IronPort-AV: E=Sophos;i="5.97,280,1669104000"; d="scan'208";a="617215419" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga003.jf.intel.com with ESMTP; 08 Feb 2023 05:31:21 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 40FEA210; Wed, 8 Feb 2023 15:32:00 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Jakub Kicinski , Xin Long , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, dev@openvswitch.org, tipc-discussion@lists.sourceforge.net Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Pravin B Shelar , Jon Maloy , Ying Xue , Simon Horman Subject: [PATCH net-next v3 2/3] genetlink: Use string_is_terminated() helper Date: Wed, 8 Feb 2023 15:31:52 +0200 Message-Id: <20230208133153.22528-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230208133153.22528-1-andriy.shevchenko@linux.intel.com> References: <20230208133153.22528-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Use string_is_terminated() helper instead of cpecific memchr() call. This shows better the intention of the call. Signed-off-by: Andy Shevchenko Reviewed-by: Simon Horman Reviewed-by: Jiri Pirko --- v3: renamed to string_is_terminated (Jakub) v2: added tag and updated subject (Simon) net/netlink/genetlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c index 600993c80050..04c4036bf406 100644 --- a/net/netlink/genetlink.c +++ b/net/netlink/genetlink.c @@ -13,7 +13,7 @@ #include #include #include -#include +#include #include #include #include @@ -457,7 +457,7 @@ static int genl_validate_assign_mc_groups(struct genl_family *family) if (WARN_ON(grp->name[0] == '\0')) return -EINVAL; - if (WARN_ON(memchr(grp->name, '\0', GENL_NAMSIZ) == NULL)) + if (WARN_ON(!string_is_terminated(grp->name, GENL_NAMSIZ))) return -EINVAL; }