| Message ID | 20230214171505.224602-2-ahalaney@redhat.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2,1/2] dt-bindings: net: snps,dwmac: Fix snps,reset-delays-us dependency | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 14/02/2023 18:15, Andrew Halaney wrote: > The deprecated property is named snps,reset-gpio, but this devicetree > used snps,reset-gpios instead which results in the reset not being used > and the following make dtbs_check error: > > ./arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: ethernet@5b050000: 'snps,reset-gpio' is a dependency of 'snps,reset-delays-us' > From schema: ./Documentation/devicetree/bindings/net/snps,dwmac.yaml > > Use the preferred method of defining the reset gpio in the phy node > itself. Note that this drops the 10 us pre-delay, but prior this wasn't > used at all and a pre-delay doesn't make much sense in this context so > it should be fine. > > Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board") > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, Feb 14, 2023 at 11:15:05AM -0600, Andrew Halaney wrote: > The deprecated property is named snps,reset-gpio, but this devicetree > used snps,reset-gpios instead which results in the reset not being used > and the following make dtbs_check error: > > ./arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: ethernet@5b050000: 'snps,reset-gpio' is a dependency of 'snps,reset-delays-us' > From schema: ./Documentation/devicetree/bindings/net/snps,dwmac.yaml > > Use the preferred method of defining the reset gpio in the phy node > itself. Note that this drops the 10 us pre-delay, but prior this wasn't > used at all and a pre-delay doesn't make much sense in this context so > it should be fine. > > Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board") > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> Applied, thanks!
diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts index 1bcf228a22b8..852420349c01 100644 --- a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts @@ -121,8 +121,6 @@ &eqos { phy-handle = <ðphy0>; nvmem-cells = <&fec_mac1>; nvmem-cell-names = "mac-address"; - snps,reset-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>; - snps,reset-delays-us = <10 20 200000>; status = "okay"; mdio { @@ -136,6 +134,9 @@ ethphy0: ethernet-phy@0 { eee-broken-1000t; qca,disable-smarteee; qca,disable-hibernation-mode; + reset-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>; + reset-assert-us = <20>; + reset-deassert-us = <200000>; vddio-supply = <&vddio0>; vddio0: vddio-regulator {
The deprecated property is named snps,reset-gpio, but this devicetree used snps,reset-gpios instead which results in the reset not being used and the following make dtbs_check error: ./arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: ethernet@5b050000: 'snps,reset-gpio' is a dependency of 'snps,reset-delays-us' From schema: ./Documentation/devicetree/bindings/net/snps,dwmac.yaml Use the preferred method of defining the reset gpio in the phy node itself. Note that this drops the 10 us pre-delay, but prior this wasn't used at all and a pre-delay doesn't make much sense in this context so it should be fine. Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board") Signed-off-by: Andrew Halaney <ahalaney@redhat.com> --- Changes since v1: * Moved the reset into the ethernet-phy node itself instead of fixing the deprecated usage (for that reason I did not collect Fabio's review tag) arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)