diff mbox series

[RFC,16/18] net: phylink: Update comment about configuring EEE in mac_link_up()

Message ID 20230217034230.1249661-17-andrew@lunn.ch (mailing list archive)
State RFC
Headers show
Series Rework MAC drivers EEE support | expand

Checks

Context Check Description
netdev/tree_selection success Guessed tree name to be net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Series has a cover letter
netdev/patch_count fail Series longer than 15 patches (and no cover letter)
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit fail Errors and warnings before: 98 this patch: 98
netdev/cc_maintainers warning 2 maintainers not CCed: linux-mediatek@lists.infradead.org linux-arm-kernel@lists.infradead.org
netdev/build_clang fail Errors and warnings before: 14 this patch: 14
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn fail Errors and warnings before: 98 this patch: 98
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 12 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Andrew Lunn Feb. 17, 2023, 3:42 a.m. UTC 
phy_init_eee() is about to be removed. If eee is active can be
determined directly from the phydev structure. Update the
documentation to indicate this.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
 include/linux/phylink.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Russell King (Oracle) Feb. 17, 2023, 11:43 a.m. UTC | #1 
On Fri, Feb 17, 2023 at 04:42:28AM +0100, Andrew Lunn wrote:
> phy_init_eee() is about to be removed. If eee is active can be
> determined directly from the phydev structure. Update the
> documentation to indicate this.
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Thanks!
diff mbox series

Patch

diff --git a/include/linux/phylink.h b/include/linux/phylink.h
index d9ea4651426d..78f25990e498 100644
--- a/include/linux/phylink.h
+++ b/include/linux/phylink.h
@@ -424,9 +424,9 @@  void mac_link_down(struct phylink_config *config, unsigned int mode,
  * be allowed when considering the implementation of this method.
  *
  * If in-band negotiation mode is disabled, allow the link to come up. If
- * @phy is non-%NULL, configure Energy Efficient Ethernet by calling
- * phy_init_eee() and perform appropriate MAC configuration for EEE.
- * Interface type selection must be done in mac_config().
+ * @phy is non-%NULL, configure Energy Efficient Ethernet in the MAC if
+ * phy->eee_active is true. Interface type selection must be done in
+ * mac_config().
  */
 void mac_link_up(struct phylink_config *config, struct phy_device *phy,
 		 unsigned int mode, phy_interface_t interface,