From patchwork Fri Feb 17 03:42:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Lunn X-Patchwork-Id: 13144291 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 337B4C636D4 for ; Fri, 17 Feb 2023 03:43:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230402AbjBQDnX (ORCPT ); Thu, 16 Feb 2023 22:43:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230332AbjBQDm7 (ORCPT ); Thu, 16 Feb 2023 22:42:59 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1229715CB9 for ; Thu, 16 Feb 2023 19:42:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:From:Sender:Reply-To:Subject:Date: Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=waNlJxho+j/jWIlWyl9YppmFv9BY1aOiis9DALxLuiA=; b=iw0uIl8gHeBizEWzCXS5dbnkZT RRmi9kRL+8ZbVeSPxbZnhiXEdohitm6+nJX/VrL3uMNGrMn1ZUc3vJt8l16mZ9gPfrAJ8DrWMf8Iz FzEHtwZgqWgqp3e+bcRlwk9UcJDmXu8IRntaFpd+muYo4Jkm1AeEPDmu/AuqiEOe9FJo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pSre0-005F71-GV; Fri, 17 Feb 2023 04:42:44 +0100 From: Andrew Lunn To: netdev Cc: Florian Fainelli , Vladimir Oltean , Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , AngeloGioacchino Del Regno , Doug Berger , Broadcom internal kernel review list , Wei Fang , Shenwei Wang , Clark Wang , NXP Linux Team , UNGLinuxDriver@microchip.com, Byungho An , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Heiner Kallweit , Russell King , Woojung Huh , Oleksij Rempel , Andrew Lunn Subject: [PATCH RFC 16/18] net: phylink: Update comment about configuring EEE in mac_link_up() Date: Fri, 17 Feb 2023 04:42:28 +0100 Message-Id: <20230217034230.1249661-17-andrew@lunn.ch> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230217034230.1249661-1-andrew@lunn.ch> References: <20230217034230.1249661-1-andrew@lunn.ch> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-State: RFC phy_init_eee() is about to be removed. If eee is active can be determined directly from the phydev structure. Update the documentation to indicate this. Signed-off-by: Andrew Lunn Reviewed-by: Russell King (Oracle) --- include/linux/phylink.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/phylink.h b/include/linux/phylink.h index d9ea4651426d..78f25990e498 100644 --- a/include/linux/phylink.h +++ b/include/linux/phylink.h @@ -424,9 +424,9 @@ void mac_link_down(struct phylink_config *config, unsigned int mode, * be allowed when considering the implementation of this method. * * If in-band negotiation mode is disabled, allow the link to come up. If - * @phy is non-%NULL, configure Energy Efficient Ethernet by calling - * phy_init_eee() and perform appropriate MAC configuration for EEE. - * Interface type selection must be done in mac_config(). + * @phy is non-%NULL, configure Energy Efficient Ethernet in the MAC if + * phy->eee_active is true. Interface type selection must be done in + * mac_config(). */ void mac_link_up(struct phylink_config *config, struct phy_device *phy, unsigned int mode, phy_interface_t interface,