diff mbox series

[net-next] netlink: remove unused 'compare' function

Message ID 20230308142006.20879-1-fw@strlen.de (mailing list archive)
State Accepted
Commit 6978052448f9eb19f7b03243ac0416104e5ee50d
Delegated to: Netdev Maintainers
Headers show
Series [net-next] netlink: remove unused 'compare' function | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 5104 this patch: 5104
netdev/cc_maintainers warning 7 maintainers not CCed: ecree.xilinx@gmail.com pabeni@redhat.com johannes@sipsolutions.net kuba@kernel.org edumazet@google.com keescook@chromium.org davem@davemloft.net
netdev/build_clang success Errors and warnings before: 1020 this patch: 1020
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 5313 this patch: 5313
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 22 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Florian Westphal March 8, 2023, 2:20 p.m. UTC
No users in the tree.  Tested with allmodconfig build.

Signed-off-by: Florian Westphal <fw@strlen.de>
---
 include/linux/netlink.h  | 1 -
 net/netlink/af_netlink.c | 2 --
 net/netlink/af_netlink.h | 1 -
 3 files changed, 4 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org March 10, 2023, 7:30 a.m. UTC | #1
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  8 Mar 2023 15:20:06 +0100 you wrote:
> No users in the tree.  Tested with allmodconfig build.
> 
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
>  include/linux/netlink.h  | 1 -
>  net/netlink/af_netlink.c | 2 --
>  net/netlink/af_netlink.h | 1 -
>  3 files changed, 4 deletions(-)

Here is the summary with links:
  - [net-next] netlink: remove unused 'compare' function
    https://git.kernel.org/netdev/net-next/c/6978052448f9

You are awesome, thank you!
diff mbox series

Patch

diff --git a/include/linux/netlink.h b/include/linux/netlink.h
index c43ac7690eca..3e8743252167 100644
--- a/include/linux/netlink.h
+++ b/include/linux/netlink.h
@@ -50,7 +50,6 @@  struct netlink_kernel_cfg {
 	struct mutex	*cb_mutex;
 	int		(*bind)(struct net *net, int group);
 	void		(*unbind)(struct net *net, int group);
-	bool		(*compare)(struct net *net, struct sock *sk);
 };
 
 struct sock *__netlink_kernel_create(struct net *net, int unit,
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index c64277659753..877f1da1a8ac 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -2097,8 +2097,6 @@  __netlink_kernel_create(struct net *net, int unit, struct module *module,
 			nl_table[unit].bind = cfg->bind;
 			nl_table[unit].unbind = cfg->unbind;
 			nl_table[unit].flags = cfg->flags;
-			if (cfg->compare)
-				nl_table[unit].compare = cfg->compare;
 		}
 		nl_table[unit].registered = 1;
 	} else {
diff --git a/net/netlink/af_netlink.h b/net/netlink/af_netlink.h
index 5f454c8de6a4..90a3198a9b7f 100644
--- a/net/netlink/af_netlink.h
+++ b/net/netlink/af_netlink.h
@@ -64,7 +64,6 @@  struct netlink_table {
 	struct module		*module;
 	int			(*bind)(struct net *net, int group);
 	void			(*unbind)(struct net *net, int group);
-	bool			(*compare)(struct net *net, struct sock *sock);
 	int			registered;
 };