| Message ID | 20230313225103.30512-14-Sergey.Semin@baikalelectronics.ru (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | dt-bindings: net: dwmac: Extend clocks, props desc and constraints | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/apply | fail | Patch does not apply to net-next |
On 13/03/2023 23:51, Serge Semin wrote: > Invalid MTL Tx Queues DT-properties description was added right at the > initial DCB/AVB features patch. Most likely due to copy-paste mistake the > text currently matches to what is specified for the AXI-bus config > properties. Let's fix that by providing correct descriptions for MTL Tx > Queue DT-properties utilized for the AVB feature (CBS algorithm) tuning. > > Fixes: 19d918731797 ("net: stmmac: configuration of CBS in case of a TX AVB queue") Fixes must be first in the patchset. > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > --- Best regards, Krzysztof
On Thu, Mar 16, 2023 at 09:08:48AM +0100, Krzysztof Kozlowski wrote: > On 13/03/2023 23:51, Serge Semin wrote: > > Invalid MTL Tx Queues DT-properties description was added right at the > > initial DCB/AVB features patch. Most likely due to copy-paste mistake the > > text currently matches to what is specified for the AXI-bus config > > properties. Let's fix that by providing correct descriptions for MTL Tx > > Queue DT-properties utilized for the AVB feature (CBS algorithm) tuning. > > > > Fixes: 19d918731797 ("net: stmmac: configuration of CBS in case of a TX AVB queue") > > Fixes must be first in the patchset. Ok. -Serge(y) > > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > --- > > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 2ebf7995426b..69be39d55403 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -321,25 +321,37 @@ properties: available in this queue. snps,send_slope: $ref: /schemas/types.yaml#/definitions/uint32 - description: enable Low Power Interface + description: + Send-Slope credit value subtracted from the accumulated credit + in the Queue for the Audio/Video bridging traffic. This is the + rate of the credit change in bits per cycle (40 ns, 8 ns and + 3.2 ns for 100 Mbps, 1000 Mbps and 2.5/10 Gbps respectively). minimum: 0 maximum: 0x3FFF snps,idle_slope: $ref: /schemas/types.yaml#/definitions/uint32 - description: unlock on WoL + description: + Idle-Slope credit value added to the accumulated credit in the + Queue with the Audio/Video bridging enabled. This is the + rate of the credit change in bits per cycle (40 ns, 8 ns and + 3.2 ns for 100 Mbps, 1000 Mbps and 2.5/10 Gbps respectively). minimum: 0 maximum: 0x8000 snps,high_credit: $ref: /schemas/types.yaml#/definitions/uint32 - description: max write outstanding req. limit + description: + Maximum value accumulated in the credit parameter for the + Audio/Video bridging feature (specified in bits scaled by 1,024). minimum: 0 maximum: 0x1FFFFFFF snps,low_credit: $ref: /schemas/types.yaml#/definitions/uint32 - description: max read outstanding req. limit + description: + Minimum value accumulated in the credit parameter for the + Audio/Video bridging feature (specified in bits scaled by 1,024). minimum: 0 maximum: 0x1FFFFFFF
Invalid MTL Tx Queues DT-properties description was added right at the initial DCB/AVB features patch. Most likely due to copy-paste mistake the text currently matches to what is specified for the AXI-bus config properties. Let's fix that by providing correct descriptions for MTL Tx Queue DT-properties utilized for the AVB feature (CBS algorithm) tuning. Fixes: 19d918731797 ("net: stmmac: configuration of CBS in case of a TX AVB queue") Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> --- .../devicetree/bindings/net/snps,dwmac.yaml | 20 +++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-)