| Message ID | 20230408152801.2336041-3-andrew@lunn.ch (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add missing DSA properties for marvell switches | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Sat, Apr 08, 2023 at 05:28:00PM +0200, Andrew Lunn wrote: > The DSA framework has got more picky about always having a phy-mode > for the CPU port. Add a phy-mode based on what the SoC ethernet is > using. For RGMII mode, have the switch add the delays. > > Additionally, the cpu label has never actually been used in the > binding, so remove it. > > Lastly add a fixed-link node indicating the expected speed/duplex of > the link to the SoC. > > Signed-off-by: Andrew Lunn <andrew@lunn.ch> > --- > v2: Use rev-rmii for the side 'playing PHY' > --- Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
diff --git a/arch/arm/boot/dts/imx6qdl-gw5904.dtsi b/arch/arm/boot/dts/imx6qdl-gw5904.dtsi index 9fc79af2bc9a..9594bc5745ed 100644 --- a/arch/arm/boot/dts/imx6qdl-gw5904.dtsi +++ b/arch/arm/boot/dts/imx6qdl-gw5904.dtsi @@ -238,8 +238,13 @@ port@3 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&fec>; + phy-mode = "rgmii-id"; + + fixed-link { + speed = <1000>; + full-duplex; + }; }; }; }; diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi index 5bb47c79a4da..abd72d72ae99 100644 --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi @@ -757,7 +757,7 @@ port@1 { port@2 { reg = <2>; - label = "cpu"; + phy-mode = "rev-rmii"; ethernet = <&fec>; fixed-link {
The DSA framework has got more picky about always having a phy-mode for the CPU port. Add a phy-mode based on what the SoC ethernet is using. For RGMII mode, have the switch add the delays. Additionally, the cpu label has never actually been used in the binding, so remove it. Lastly add a fixed-link node indicating the expected speed/duplex of the link to the SoC. Signed-off-by: Andrew Lunn <andrew@lunn.ch> --- v2: Use rev-rmii for the side 'playing PHY' --- arch/arm/boot/dts/imx6qdl-gw5904.dtsi | 7 ++++++- arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-)