| Message ID | 20230412124737.2243527-5-vladimir.oltean@nxp.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 93f0f93bbdb9ebf3d2831e8023cae4f31cb83cee |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Ocelot/Felix driver cleanup | expand |
| Context | Check | Description |
|---|---|---|
| netdev/series_format | success | Posting correctly formatted |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 18 this patch: 18 |
| netdev/cc_maintainers | success | CCed 9 of 9 maintainers |
| netdev/build_clang | success | Errors and warnings before: 18 this patch: 18 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/deprecated_api | success | None detected |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 18 this patch: 18 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 3 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Wed, Apr 12, 2023 at 03:47:33PM +0300, Vladimir Oltean wrote: > Commit a3bb8f521fd8 ("net: mscc: ocelot: remove unnecessary exposure of > stats structures") made an unnecessary change which was to add a new > line at the end of ocelot_stats.c. Remove it. Yes it did. Apologies. Acked-by: Colin Foster <colin.foster@in-advantage.com> > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > --- > drivers/net/ethernet/mscc/ocelot_stats.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/mscc/ocelot_stats.c b/drivers/net/ethernet/mscc/ocelot_stats.c > index b50d9d9f8023..99a14a942600 100644 > --- a/drivers/net/ethernet/mscc/ocelot_stats.c > +++ b/drivers/net/ethernet/mscc/ocelot_stats.c > @@ -981,4 +981,3 @@ void ocelot_stats_deinit(struct ocelot *ocelot) > cancel_delayed_work(&ocelot->stats_work); > destroy_workqueue(ocelot->stats_queue); > } > - > -- > 2.34.1 >
On 4/12/2023 5:47 AM, Vladimir Oltean wrote: > Commit a3bb8f521fd8 ("net: mscc: ocelot: remove unnecessary exposure of > stats structures") made an unnecessary change which was to add a new > line at the end of ocelot_stats.c. Remove it. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > --- > drivers/net/ethernet/mscc/ocelot_stats.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/mscc/ocelot_stats.c b/drivers/net/ethernet/mscc/ocelot_stats.c > index b50d9d9f8023..99a14a942600 100644 > --- a/drivers/net/ethernet/mscc/ocelot_stats.c > +++ b/drivers/net/ethernet/mscc/ocelot_stats.c > @@ -981,4 +981,3 @@ void ocelot_stats_deinit(struct ocelot *ocelot) > cancel_delayed_work(&ocelot->stats_work); > destroy_workqueue(ocelot->stats_queue); > } > - Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
diff --git a/drivers/net/ethernet/mscc/ocelot_stats.c b/drivers/net/ethernet/mscc/ocelot_stats.c index b50d9d9f8023..99a14a942600 100644 --- a/drivers/net/ethernet/mscc/ocelot_stats.c +++ b/drivers/net/ethernet/mscc/ocelot_stats.c @@ -981,4 +981,3 @@ void ocelot_stats_deinit(struct ocelot *ocelot) cancel_delayed_work(&ocelot->stats_work); destroy_workqueue(ocelot->stats_queue); } -
Commit a3bb8f521fd8 ("net: mscc: ocelot: remove unnecessary exposure of stats structures") made an unnecessary change which was to add a new line at the end of ocelot_stats.c. Remove it. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- drivers/net/ethernet/mscc/ocelot_stats.c | 1 - 1 file changed, 1 deletion(-)