| Message ID | 20230419062018.286136-3-saikrishnag@marvell.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | octeontx2: Miscellaneous fixes | expand |
| Context | Check | Description |
|---|---|---|
| netdev/series_format | success | Posting correctly formatted |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/fixes_present | success | Fixes tag present in non-next series |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 18 this patch: 18 |
| netdev/cc_maintainers | success | CCed 12 of 12 maintainers |
| netdev/build_clang | success | Errors and warnings before: 18 this patch: 18 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/deprecated_api | success | None detected |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | Fixes tag looks correct |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 18 this patch: 18 |
| netdev/checkpatch | warning | WARNING: line length of 94 exceeds 80 columns |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Wed, Apr 19, 2023 at 11:50:10AM +0530, Sai Krishna wrote: > From: Ratheesh Kannoth <rkannoth@marvell.com> > > Fix the NPC nibble start and end positions in the bit > map. for_each_set_bit_from() needs start bit as one bit prior > and end bit as one bit post position in the bit map > > Fixes: b747923afff8 ("octeontx2-af: Exact match support") > Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com> > Signed-off-by: Sai Krishna <saikrishnag@marvell.com> I think it would be nice to explain why, and what effect this has. Also, TBH, I'm unsure why the start needs to be one bit prior. > --- > drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c > index 006beb5cf98d..27603078689a 100644 > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c > @@ -593,9 +593,8 @@ static int npc_scan_kex(struct rvu *rvu, int blkaddr, u8 intf) > * exact match code. > */ > masked_cfg = cfg & NPC_EXACT_NIBBLE; > - bitnr = NPC_EXACT_NIBBLE_START; > - for_each_set_bit_from(bitnr, (unsigned long *)&masked_cfg, > - NPC_EXACT_NIBBLE_START) { > + bitnr = NPC_EXACT_NIBBLE_START - 1; > + for_each_set_bit_from(bitnr, (unsigned long *)&masked_cfg, NPC_EXACT_NIBBLE_END + 1) { > npc_scan_exact_result(mcam, bitnr, key_nibble, intf); > key_nibble++; > } > -- > 2.25.1 >
> -----Original Message----- > From: Simon Horman <simon.horman@corigine.com> > Sent: Wednesday, April 19, 2023 4:05 PM > To: Sai Krishna Gajula <saikrishnag@marvell.com> > Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org; > pabeni@redhat.com; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; leon@kernel.org; Sunil Kovvuri Goutham > <sgoutham@marvell.com>; Geethasowjanya Akula <gakula@marvell.com>; > Linu Cherian <lcherian@marvell.com>; Jerin Jacob Kollanukkaran > <jerinj@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>; > Subbaraya Sundeep Bhatta <sbhatta@marvell.com>; Ratheesh Kannoth > <rkannoth@marvell.com> > Subject: Re: [net PATCH v3 02/10] octeontx2-af: Fix start and end bit for > scan config > > On Wed, Apr 19, 2023 at 11:50:10AM +0530, Sai Krishna wrote: > > From: Ratheesh Kannoth <rkannoth@marvell.com> > > > > Fix the NPC nibble start and end positions in the bit map. > > for_each_set_bit_from() needs start bit as one bit prior and end bit > > as one bit post position in the bit map > > > > Fixes: b747923afff8 ("octeontx2-af: Exact match support") > > Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com> > > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com> > > Signed-off-by: Sai Krishna <saikrishnag@marvell.com> > > I think it would be nice to explain why, and what effect this has. > > Also, TBH, I'm unsure why the start needs to be one bit prior. > Will expand the commit message with explanation of why, what effect of fix in v4 patch. > > --- > > drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c > > b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c > > index 006beb5cf98d..27603078689a 100644 > > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c > > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c > > @@ -593,9 +593,8 @@ static int npc_scan_kex(struct rvu *rvu, int blkaddr, > u8 intf) > > * exact match code. > > */ > > masked_cfg = cfg & NPC_EXACT_NIBBLE; > > - bitnr = NPC_EXACT_NIBBLE_START; > > - for_each_set_bit_from(bitnr, (unsigned long *)&masked_cfg, > > - NPC_EXACT_NIBBLE_START) { > > + bitnr = NPC_EXACT_NIBBLE_START - 1; > > + for_each_set_bit_from(bitnr, (unsigned long *)&masked_cfg, > > +NPC_EXACT_NIBBLE_END + 1) { > > npc_scan_exact_result(mcam, bitnr, key_nibble, intf); > > key_nibble++; > > } > > -- > > 2.25.1 > >
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c index 006beb5cf98d..27603078689a 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c @@ -593,9 +593,8 @@ static int npc_scan_kex(struct rvu *rvu, int blkaddr, u8 intf) * exact match code. */ masked_cfg = cfg & NPC_EXACT_NIBBLE; - bitnr = NPC_EXACT_NIBBLE_START; - for_each_set_bit_from(bitnr, (unsigned long *)&masked_cfg, - NPC_EXACT_NIBBLE_START) { + bitnr = NPC_EXACT_NIBBLE_START - 1; + for_each_set_bit_from(bitnr, (unsigned long *)&masked_cfg, NPC_EXACT_NIBBLE_END + 1) { npc_scan_exact_result(mcam, bitnr, key_nibble, intf); key_nibble++; }