| Message ID | 20230426104313.28950-2-harini.katakam@amd.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add support for VSC8531_02 PHY and DT RGMII tuning | expand |
On Wed, Apr 26, 2023 at 04:13:11PM +0530, Harini Katakam wrote: > All the PHY devices variants specified have the same mask and > hence can be simplified to one vendor look up for 0xfffffff0. > Any individual config can be identified by PHY_ID_MATCH_EXACT > in the respective structure. > > Signed-off-by: Harini Katakam <harini.katakam@amd.com> net-next is closed at the moment, so you will need to report in two weeks time. > diff --git a/drivers/net/phy/mscc/mscc_main.c b/drivers/net/phy/mscc/mscc_main.c > index 62bf99e45af1..75d9582e5784 100644 > --- a/drivers/net/phy/mscc/mscc_main.c > +++ b/drivers/net/phy/mscc/mscc_main.c > @@ -2656,19 +2656,7 @@ static struct phy_driver vsc85xx_driver[] = { > module_phy_driver(vsc85xx_driver); > > static struct mdio_device_id __maybe_unused vsc85xx_tbl[] = { > - { PHY_ID_VSC8504, 0xfffffff0, }, > - { PHY_ID_VSC8514, 0xfffffff0, }, > - { PHY_ID_VSC8530, 0xfffffff0, }, > - { PHY_ID_VSC8531, 0xfffffff0, }, > - { PHY_ID_VSC8540, 0xfffffff0, }, > - { PHY_ID_VSC8541, 0xfffffff0, }, > - { PHY_ID_VSC8552, 0xfffffff0, }, > - { PHY_ID_VSC856X, 0xfffffff0, }, > - { PHY_ID_VSC8572, 0xfffffff0, }, > - { PHY_ID_VSC8574, 0xfffffff0, }, > - { PHY_ID_VSC8575, 0xfffffff0, }, > - { PHY_ID_VSC8582, 0xfffffff0, }, > - { PHY_ID_VSC8584, 0xfffffff0, }, > + { PHY_ID_MATCH_VENDOR(0xfffffff0) }, The vendor ID is 0xfffffff0 ??? Andrew
Hi Andrew, > -----Original Message----- > From: Andrew Lunn <andrew@lunn.ch> > Sent: Wednesday, April 26, 2023 7:10 PM > To: Katakam, Harini <harini.katakam@amd.com> > Cc: robh+dt@kernel.org; hkallweit1@gmail.com; linux@armlinux.org.uk; > davem@davemloft.net; kuba@kernel.org; edumazet@google.com; > pabeni@redhat.com; vladimir.oltean@nxp.com; wsa+renesas@sang- > engineering.com; krzysztof.kozlowski+dt@linaro.org; > simon.horman@corigine.com; netdev@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > harinikatakamlinux@gmail.com; Simek, Michal <michal.simek@amd.com>; > Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com> > Subject: Re: [PATCH net-next v2 1/3] phy: mscc: Use > PHY_ID_MATCH_VENDOR to minimize PHY ID table > > On Wed, Apr 26, 2023 at 04:13:11PM +0530, Harini Katakam wrote: > > All the PHY devices variants specified have the same mask and hence > > can be simplified to one vendor look up for 0xfffffff0. > > Any individual config can be identified by PHY_ID_MATCH_EXACT in the > > respective structure. > > > > Signed-off-by: Harini Katakam <harini.katakam@amd.com> > <snip> > > + { PHY_ID_MATCH_VENDOR(0xfffffff0) }, > > The vendor ID is 0xfffffff0 ??? Sorry this is supposed to be 0x00070400 (Microsemi OUI). Will fix in the next version. Regards, Harini
diff --git a/drivers/net/phy/mscc/mscc_main.c b/drivers/net/phy/mscc/mscc_main.c index 62bf99e45af1..75d9582e5784 100644 --- a/drivers/net/phy/mscc/mscc_main.c +++ b/drivers/net/phy/mscc/mscc_main.c @@ -2656,19 +2656,7 @@ static struct phy_driver vsc85xx_driver[] = { module_phy_driver(vsc85xx_driver); static struct mdio_device_id __maybe_unused vsc85xx_tbl[] = { - { PHY_ID_VSC8504, 0xfffffff0, }, - { PHY_ID_VSC8514, 0xfffffff0, }, - { PHY_ID_VSC8530, 0xfffffff0, }, - { PHY_ID_VSC8531, 0xfffffff0, }, - { PHY_ID_VSC8540, 0xfffffff0, }, - { PHY_ID_VSC8541, 0xfffffff0, }, - { PHY_ID_VSC8552, 0xfffffff0, }, - { PHY_ID_VSC856X, 0xfffffff0, }, - { PHY_ID_VSC8572, 0xfffffff0, }, - { PHY_ID_VSC8574, 0xfffffff0, }, - { PHY_ID_VSC8575, 0xfffffff0, }, - { PHY_ID_VSC8582, 0xfffffff0, }, - { PHY_ID_VSC8584, 0xfffffff0, }, + { PHY_ID_MATCH_VENDOR(0xfffffff0) }, { } };
All the PHY devices variants specified have the same mask and hence can be simplified to one vendor look up for 0xfffffff0. Any individual config can be identified by PHY_ID_MATCH_EXACT in the respective structure. Signed-off-by: Harini Katakam <harini.katakam@amd.com> --- v2: New patch drivers/net/phy/mscc/mscc_main.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-)