From patchwork Wed Jun 7 07:54:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Chan X-Patchwork-Id: 13270118 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC2C37465 for ; Wed, 7 Jun 2023 07:54:44 +0000 (UTC) Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7724C10C6 for ; Wed, 7 Jun 2023 00:54:43 -0700 (PDT) Received: by mail-qv1-xf2e.google.com with SMTP id 6a1803df08f44-62b65e4c42eso6758226d6.3 for ; Wed, 07 Jun 2023 00:54:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1686124482; x=1688716482; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=00fRL8RxD9SowKNUqYjLLBgtoj6CGuSVSaOL5LoZUh0=; b=Hj6Zfq/t9PX5vlpNJfmgNqItzpMyg9RnWNixOonRgJpod2PJrPVFOzO852q6owz3ke 5LSuH3QTpaD+Bor3cvsAXVZ12ZfSIULteCIN+lzSBF54WMf7mpDpawJY8Cq7OtWM33NA veIyqKABxSl4/8zsaHCKOfXoFlchrkssl5864= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686124482; x=1688716482; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=00fRL8RxD9SowKNUqYjLLBgtoj6CGuSVSaOL5LoZUh0=; b=LxtN18805l1cUCNEC4GFWSld06VutG198SJssr4KOazQfzRwoDmTh2EGPcKxNv7eUi ZS1wSJ6xfgP02BoA3wYJlWAIFaoBG9I7NpYWYn4shs94CEU5/kPJt2CvfDjM+XsqWku9 1vrIrdlwQpHNa8qrGby8c7+Qq/N+RpZPxvHsAgRvsgP4oRYN1JjyE9eWpRal0emIP32B BjzFguqBT/BHyHg2nZ0lm5CsN+0Y9pQz0ej32jXcpUgGJSe3sHB4jPXDZKGSfuJ8lbnT 2dLYYAC9ZRSbH1tlgknD3f+OCQgXehBitI1fAuOeXqN/eT0So6SXcLguDR3woJ5eI1nW o+jA== X-Gm-Message-State: AC+VfDyMxpy4Z8UsCCFRA0IqS565VFQtqjCloRRmDEGmw0PYHvMlXpDH cbrR2wOdr42d7LG3J3V5Mb5s/MH0ln3S5gXika4= X-Google-Smtp-Source: ACHHUZ54AXTNz0Qg8k+NtWfSiZBv4kFwJDYB/0K+y3bDEiMTmtWzHw+ScOei7qCz+X9/m9w8mqPGeg== X-Received: by 2002:ad4:5747:0:b0:629:78ae:80f0 with SMTP id q7-20020ad45747000000b0062978ae80f0mr2786147qvx.8.1686124482516; Wed, 07 Jun 2023 00:54:42 -0700 (PDT) Received: from lvnvda5233.lvn.broadcom.net ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id cs12-20020ad44c4c000000b00626362f1bf1sm5850817qvb.63.2023.06.07.00.54.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Jun 2023 00:54:41 -0700 (PDT) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, gospo@broadcom.com, Pavan Chebbi , Kalesh Anakkur Purayil , Somnath Kotur Subject: [PATCH net 1/6] bnxt_en: Fix bnxt_hwrm_update_rss_hash_cfg() Date: Wed, 7 Jun 2023 00:54:04 -0700 Message-Id: <20230607075409.228450-2-michael.chan@broadcom.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20230607075409.228450-1-michael.chan@broadcom.com> References: <20230607075409.228450-1-michael.chan@broadcom.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org From: Pavan Chebbi We must specify the vnic id of the vnic in the input structure of this firmware message. Otherwise we will get an error from the firmware. Fixes: 98a4322b70e8 ("bnxt_en: update RSS config using difference algorithm") Reviewed-by: Kalesh Anakkur Purayil Reviewed-by: Somnath Kotur Signed-off-by: Pavan Chebbi Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index dcd9367f05af..4aa490cb2fe0 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -5350,6 +5350,7 @@ static void bnxt_hwrm_update_rss_hash_cfg(struct bnxt *bp) if (hwrm_req_init(bp, req, HWRM_VNIC_RSS_QCFG)) return; + req->vnic_id = cpu_to_le16(vnic->fw_vnic_id); /* all contexts configured to same hash_type, zero always exists */ req->rss_ctx_idx = cpu_to_le16(vnic->fw_rss_cos_lb_ctx[0]); resp = hwrm_req_hold(bp, req);