| Message ID | 20230608080316.84203-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [-next] net: hv_netvsc: Remove duplicated include in rndis_filter.c | expand |
On Thu, Jun 08, 2023 at 04:03:16PM +0800, Yang Li wrote: > ./drivers/net/hyperv/rndis_filter.c: linux/slab.h is included more than once. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5462 > Fixes: 4cab498f33f7 ("hv_netvsc: Allocate rx indirection table size dynamically") > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Hi Yang Li, A few nits from my side; 1. The subject should include the target tree, in this case net-next. [PATCH net-next] ... 2. I don't think this needs a fixes tag: nothing was broken I'm not sure this warrants a v2. If you do decide to post a v2, please allow for 24h since v1 was posted. Link: https://kernel.org/doc/html/v6.3/process/maintainer-netdev.html Lastly, I think at least one other similar change has been posted recently. Please consider batching up such changes, say in groups of 10 patches, and posting them as a patch-set. The change itself seems fine to me. Reviewed-by: Simon Horman <simon.horman@corigine.com> > --- > drivers/net/hyperv/rndis_filter.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c > index af95947a87c5..ecc2128ca9b7 100644 > --- a/drivers/net/hyperv/rndis_filter.c > +++ b/drivers/net/hyperv/rndis_filter.c > @@ -21,7 +21,6 @@ > #include <linux/rtnetlink.h> > #include <linux/ucs2_string.h> > #include <linux/string.h> > -#include <linux/slab.h> > > #include "hyperv_net.h" > #include "netvsc_trace.h" > -- > 2.20.1.7.g153144c > >
diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c index af95947a87c5..ecc2128ca9b7 100644 --- a/drivers/net/hyperv/rndis_filter.c +++ b/drivers/net/hyperv/rndis_filter.c @@ -21,7 +21,6 @@ #include <linux/rtnetlink.h> #include <linux/ucs2_string.h> #include <linux/string.h> -#include <linux/slab.h> #include "hyperv_net.h" #include "netvsc_trace.h"
./drivers/net/hyperv/rndis_filter.c: linux/slab.h is included more than once. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5462 Fixes: 4cab498f33f7 ("hv_netvsc: Allocate rx indirection table size dynamically") Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/net/hyperv/rndis_filter.c | 1 - 1 file changed, 1 deletion(-)