| Message ID | 20230728183945.760531-1-florian.fainelli@broadcom.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | df41fa677d9b4717c930afbe88b06f5cefdacb21 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: bcmgenet: Remove TX ring full logging | expand |
On Fri, Jul 28, 2023 at 11:39:45AM -0700, Florian Fainelli wrote: > There is no need to spam the kernel log with such an indication, remove > this message. > > Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 28 Jul 2023 11:39:45 -0700 you wrote: > There is no need to spam the kernel log with such an indication, remove > this message. > > Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> > --- > drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) Here is the summary with links: - [net-next] net: bcmgenet: Remove TX ring full logging https://git.kernel.org/netdev/net-next/c/df41fa677d9b You are awesome, thank you!
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index 2b5761ad2f92..24bade875ca6 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -2077,12 +2077,8 @@ static netdev_tx_t bcmgenet_xmit(struct sk_buff *skb, struct net_device *dev) spin_lock(&ring->lock); if (ring->free_bds <= (nr_frags + 1)) { - if (!netif_tx_queue_stopped(txq)) { + if (!netif_tx_queue_stopped(txq)) netif_tx_stop_queue(txq); - netdev_err(dev, - "%s: tx ring %d full when queue %d awake\n", - __func__, index, ring->queue); - } ret = NETDEV_TX_BUSY; goto out; }
There is no need to spam the kernel log with such an indication, remove this message. Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)