| Message ID | 20230803023128.3753323-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 09d15054c467e92e750d489cd0cb9df834c18464 |
| Delegated to: | BPF |
| Headers | show |
| Series | [-next] bpf: change bpf_alu_sign_string and bpf_movsx_string to static | expand |
On 8/2/23 7:31 PM, Yang Yingliang wrote: > The bpf_alu_sign_string and bpf_movsx_string introduced in commit > f835bb622299 ("bpf: Add kernel/bpftool asm support for new instructions") > are only used in disasm.c now, change them to static. > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Thanks for the fix! Acked-by: Yonghong Song <yonghong.song@linux.dev>
Hello: This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <martin.lau@kernel.org>: On Thu, 3 Aug 2023 10:31:28 +0800 you wrote: > The bpf_alu_sign_string and bpf_movsx_string introduced in commit > f835bb622299 ("bpf: Add kernel/bpftool asm support for new instructions") > are only used in disasm.c now, change them to static. > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > kernel/bpf/disasm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Here is the summary with links: - [-next] bpf: change bpf_alu_sign_string and bpf_movsx_string to static https://git.kernel.org/bpf/bpf-next/c/09d15054c467 You are awesome, thank you!
diff --git a/kernel/bpf/disasm.c b/kernel/bpf/disasm.c index d7bff608f299..d99ab716d78e 100644 --- a/kernel/bpf/disasm.c +++ b/kernel/bpf/disasm.c @@ -87,12 +87,12 @@ const char *const bpf_alu_string[16] = { [BPF_END >> 4] = "endian", }; -const char *const bpf_alu_sign_string[16] = { +static const char *const bpf_alu_sign_string[16] = { [BPF_DIV >> 4] = "s/=", [BPF_MOD >> 4] = "s%=", }; -const char *const bpf_movsx_string[4] = { +static const char *const bpf_movsx_string[4] = { [0] = "(s8)", [1] = "(s16)", [3] = "(s32)",
The bpf_alu_sign_string and bpf_movsx_string introduced in commit f835bb622299 ("bpf: Add kernel/bpftool asm support for new instructions") are only used in disasm.c now, change them to static. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- kernel/bpf/disasm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)