| Message ID | 20230803134248.42652-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | wifi: iw_handler.h: Remove unused declaration dev_get_wireless_info() | expand |
On Thu, Aug 03, 2023 at 09:42:48PM +0800, Yue Haibing wrote: > Commit 556829657397 ("[NL80211]: add netlink interface to cfg80211") > declared but never implemented this, remove it. > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> > --- > include/net/iw_handler.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/include/net/iw_handler.h b/include/net/iw_handler.h > index d2ea5863eedc..99f46f521aa7 100644 > --- a/include/net/iw_handler.h > +++ b/include/net/iw_handler.h > @@ -432,9 +432,6 @@ struct iw_public_data { > > /* First : function strictly used inside the kernel */ > Hi Yue Haibing, I think you can remove the comment above and blank line below it too. > -/* Handle /proc/net/wireless, called in net/code/dev.c */ > -int dev_get_wireless_info(char *buffer, char **start, off_t offset, int length); > - > /* Second : functions that may be called by driver modules */ And work this into the comment above the to be deleted 'First :' comment. Something like this: /* * Functions part of the Wireless Extensions (defined in net/core/wireless.c). * These may be called by driver modules. */ > > /* Send a single event to user space */ > -- > 2.34.1 > >
On 2023/8/4 2:03, Simon Horman wrote: > On Thu, Aug 03, 2023 at 09:42:48PM +0800, Yue Haibing wrote: >> Commit 556829657397 ("[NL80211]: add netlink interface to cfg80211") >> declared but never implemented this, remove it. >> >> Signed-off-by: Yue Haibing <yuehaibing@huawei.com> >> --- >> include/net/iw_handler.h | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/include/net/iw_handler.h b/include/net/iw_handler.h >> index d2ea5863eedc..99f46f521aa7 100644 >> --- a/include/net/iw_handler.h >> +++ b/include/net/iw_handler.h >> @@ -432,9 +432,6 @@ struct iw_public_data { >> >> /* First : function strictly used inside the kernel */ >> > > Hi Yue Haibing, > > I think you can remove the comment above and blank line below it too. > >> -/* Handle /proc/net/wireless, called in net/code/dev.c */ >> -int dev_get_wireless_info(char *buffer, char **start, off_t offset, int length); >> - >> /* Second : functions that may be called by driver modules */ > > And work this into the comment above the to be deleted 'First :' comment. > Something like this: Thanks, will rework. > > /* > * Functions part of the Wireless Extensions (defined in net/core/wireless.c). > * These may be called by driver modules. > */ > >> >> /* Send a single event to user space */ >> -- >> 2.34.1 >> >> > . >
diff --git a/include/net/iw_handler.h b/include/net/iw_handler.h index d2ea5863eedc..99f46f521aa7 100644 --- a/include/net/iw_handler.h +++ b/include/net/iw_handler.h @@ -432,9 +432,6 @@ struct iw_public_data { /* First : function strictly used inside the kernel */ -/* Handle /proc/net/wireless, called in net/code/dev.c */ -int dev_get_wireless_info(char *buffer, char **start, off_t offset, int length); - /* Second : functions that may be called by driver modules */ /* Send a single event to user space */
Commit 556829657397 ("[NL80211]: add netlink interface to cfg80211") declared but never implemented this, remove it. Signed-off-by: Yue Haibing <yuehaibing@huawei.com> --- include/net/iw_handler.h | 3 --- 1 file changed, 3 deletions(-)