| Message ID | 20230804133617.43564-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] wifi: iw_handler.h: Remove unused declaration dev_get_wireless_info() | expand |
On Fri, Aug 04, 2023 at 09:36:17PM +0800, Yue Haibing wrote: > Commit 556829657397 ("[NL80211]: add netlink interface to cfg80211") > declared but never implemented this, remove it. > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> > --- > v2: fix comment > --- > include/net/iw_handler.h | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/include/net/iw_handler.h b/include/net/iw_handler.h > index d2ea5863eedc..b2cf243ebe44 100644 > --- a/include/net/iw_handler.h > +++ b/include/net/iw_handler.h > @@ -426,17 +426,10 @@ struct iw_public_data { > > /**************************** PROTOTYPES ****************************/ > /* > - * Functions part of the Wireless Extensions (defined in net/core/wireless.c). > - * Those may be called only within the kernel. > + * Functions part of the Wireless Extensions (defined in net/wireless/wext-core.c). Can I confirm that the wireless.c -> wext-core.c change is intentional? It doesn't seem strictly related to the patch description. > + * Those may be called by driver modules. > */ > > -/* First : function strictly used inside the kernel */ > - > -/* Handle /proc/net/wireless, called in net/code/dev.c */ > -int dev_get_wireless_info(char *buffer, char **start, off_t offset, int length); > - > -/* Second : functions that may be called by driver modules */ > - > /* Send a single event to user space */ > void wireless_send_event(struct net_device *dev, unsigned int cmd, > union iwreq_data *wrqu, const char *extra); > -- > 2.34.1 >
On 2023/8/5 15:53, Simon Horman wrote: > On Fri, Aug 04, 2023 at 09:36:17PM +0800, Yue Haibing wrote: >> Commit 556829657397 ("[NL80211]: add netlink interface to cfg80211") >> declared but never implemented this, remove it. >> >> Signed-off-by: Yue Haibing <yuehaibing@huawei.com> >> --- >> v2: fix comment >> --- >> include/net/iw_handler.h | 11 ++--------- >> 1 file changed, 2 insertions(+), 9 deletions(-) >> >> diff --git a/include/net/iw_handler.h b/include/net/iw_handler.h >> index d2ea5863eedc..b2cf243ebe44 100644 >> --- a/include/net/iw_handler.h >> +++ b/include/net/iw_handler.h >> @@ -426,17 +426,10 @@ struct iw_public_data { >> >> /**************************** PROTOTYPES ****************************/ >> /* >> - * Functions part of the Wireless Extensions (defined in net/core/wireless.c). >> - * Those may be called only within the kernel. >> + * Functions part of the Wireless Extensions (defined in net/wireless/wext-core.c). > > Can I confirm that the wireless.c -> wext-core.c change is intentional? > It doesn't seem strictly related to the patch description. Commit 11433ee450eb ("[WEXT]: Move to net/wireless") rename net/core/wireless.c to net/wireless/wext.c then commit 3d23e349d807 ("wext: refactor") refactor wext.c to wext-core.c The wext functions now sits in net/wireless/wext-core.c This may need describe in patch description. > >> + * Those may be called by driver modules. >> */ >> >> -/* First : function strictly used inside the kernel */ >> - >> -/* Handle /proc/net/wireless, called in net/code/dev.c */ >> -int dev_get_wireless_info(char *buffer, char **start, off_t offset, int length); >> - >> -/* Second : functions that may be called by driver modules */ >> - >> /* Send a single event to user space */ >> void wireless_send_event(struct net_device *dev, unsigned int cmd, >> union iwreq_data *wrqu, const char *extra); >> -- >> 2.34.1 >> > . >
On Sat, Aug 05, 2023 at 04:24:04PM +0800, Yue Haibing wrote: > On 2023/8/5 15:53, Simon Horman wrote: > > On Fri, Aug 04, 2023 at 09:36:17PM +0800, Yue Haibing wrote: > >> Commit 556829657397 ("[NL80211]: add netlink interface to cfg80211") > >> declared but never implemented this, remove it. > >> > >> Signed-off-by: Yue Haibing <yuehaibing@huawei.com> > >> --- > >> v2: fix comment > >> --- > >> include/net/iw_handler.h | 11 ++--------- > >> 1 file changed, 2 insertions(+), 9 deletions(-) > >> > >> diff --git a/include/net/iw_handler.h b/include/net/iw_handler.h > >> index d2ea5863eedc..b2cf243ebe44 100644 > >> --- a/include/net/iw_handler.h > >> +++ b/include/net/iw_handler.h > >> @@ -426,17 +426,10 @@ struct iw_public_data { > >> > >> /**************************** PROTOTYPES ****************************/ > >> /* > >> - * Functions part of the Wireless Extensions (defined in net/core/wireless.c). > >> - * Those may be called only within the kernel. > >> + * Functions part of the Wireless Extensions (defined in net/wireless/wext-core.c). > > > > Can I confirm that the wireless.c -> wext-core.c change is intentional? > > It doesn't seem strictly related to the patch description. > > Commit 11433ee450eb ("[WEXT]: Move to net/wireless") rename net/core/wireless.c to net/wireless/wext.c > then commit 3d23e349d807 ("wext: refactor") refactor wext.c to wext-core.c > The wext functions now sits in net/wireless/wext-core.c > This may need describe in patch description. Thanks, I think that would be best ...
diff --git a/include/net/iw_handler.h b/include/net/iw_handler.h index d2ea5863eedc..b2cf243ebe44 100644 --- a/include/net/iw_handler.h +++ b/include/net/iw_handler.h @@ -426,17 +426,10 @@ struct iw_public_data { /**************************** PROTOTYPES ****************************/ /* - * Functions part of the Wireless Extensions (defined in net/core/wireless.c). - * Those may be called only within the kernel. + * Functions part of the Wireless Extensions (defined in net/wireless/wext-core.c). + * Those may be called by driver modules. */ -/* First : function strictly used inside the kernel */ - -/* Handle /proc/net/wireless, called in net/code/dev.c */ -int dev_get_wireless_info(char *buffer, char **start, off_t offset, int length); - -/* Second : functions that may be called by driver modules */ - /* Send a single event to user space */ void wireless_send_event(struct net_device *dev, unsigned int cmd, union iwreq_data *wrqu, const char *extra);
Commit 556829657397 ("[NL80211]: add netlink interface to cfg80211") declared but never implemented this, remove it. Signed-off-by: Yue Haibing <yuehaibing@huawei.com> --- v2: fix comment --- include/net/iw_handler.h | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)