| Message ID | 20230808210436.838995-5-andrew@lunn.ch (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e8fbcc47a8e935f36f044d85f21a99acecbd7bfb |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Support offload LED blinking to PHY. | expand |
On Tue, Aug 08, 2023 at 11:04:36PM +0200, Andrew Lunn wrote: > Ensure that the offloading of blinking is stopped when the trigger is > deactivated. Calling led_set_brightness() is documented as stopping > offload and setting the LED to a constant brightness. > > Suggested-by: Daniel Golle <daniel@makrotopia.org> > Signed-off-by: Andrew Lunn <andrew@lunn.ch> Reviewed-by: Simon Horman <simon.horman@corigine.com>
diff --git a/drivers/leds/trigger/ledtrig-netdev.c b/drivers/leds/trigger/ledtrig-netdev.c index 3d215a556e20..42f758880ef8 100644 --- a/drivers/leds/trigger/ledtrig-netdev.c +++ b/drivers/leds/trigger/ledtrig-netdev.c @@ -595,6 +595,8 @@ static void netdev_trig_deactivate(struct led_classdev *led_cdev) cancel_delayed_work_sync(&trigger_data->work); + led_set_brightness(led_cdev, LED_OFF); + dev_put(trigger_data->net_dev); kfree(trigger_data);
Ensure that the offloading of blinking is stopped when the trigger is deactivated. Calling led_set_brightness() is documented as stopping offload and setting the LED to a constant brightness. Suggested-by: Daniel Golle <daniel@makrotopia.org> Signed-off-by: Andrew Lunn <andrew@lunn.ch> --- drivers/leds/trigger/ledtrig-netdev.c | 2 ++ 1 file changed, 2 insertions(+)