| Message ID | 20230810024422.1781312-1-rkannoth@marvell.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] octeontx2-pf: Set page pool size | expand |
From: Ratheesh Kannoth <rkannoth@marvell.com> Date: Thu, 10 Aug 2023 08:14:22 +0530 > page pool infra does direct recycling aggressively. > This would often keep ptr_ring left unused. Save > memory by configuring ptr_ring to a constant value(2K). > > Please find discussion at > https://lore.kernel.org/netdev/ > 15d32b22-22b0-64e3-a49e-88d780c24616@kernel.org/T/ > > Fixes: b2e3406a38f0 ("octeontx2-pf: Add support for page pool") Now the commit message doesn't explain why this is a fix. The subject is also ambigous. In the subject, you need to say clearly what you're fixing. E.g. "fix page_pool creation fail for rings > 32k". In the commitmsg, provide the actual kernel warning/error and explain some implementation details, like: "instead of clamping page_pool size to 32k at most, limit it even more to 2k to avoid wasting memory on much less used now ptr_ring". > Suggested-by: Alexander Lobakin <aleksander.lobakin@intel.com> > Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com> > --- > drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c > index 77c8f650f7ac..123348a9e19e 100644 > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c > @@ -1432,7 +1432,8 @@ int otx2_pool_init(struct otx2_nic *pfvf, u16 pool_id, > } > > pp_params.flags = PP_FLAG_PAGE_FRAG | PP_FLAG_DMA_MAP; > - pp_params.pool_size = numptrs; > +#define OTX2_PAGE_POOL_SZ 2048 > + pp_params.pool_size = OTX2_PAGE_POOL_SZ; And if the ring size is e.g. 256 or 512 or even 1024, why have Page Pool with 2048 elements? Should be something like min(numptrs, OTX2_PAGE_POOL_MAX_SZ) And please place the definition somewhere next to other definitions at the top of the file or in some header, dunno. Placing it inside the function almost guarantees you won't be able to find it one day. > pp_params.nid = NUMA_NO_NODE; > pp_params.dev = pfvf->dev; > pp_params.dma_dir = DMA_FROM_DEVICE; Thanks, Olek
On Thu, 10 Aug 2023 19:09:21 +0200 Alexander Lobakin wrote: > And if the ring size is e.g. 256 or 512 or even 1024, why have Page Pool > with 2048 elements? Should be something like > > min(numptrs, OTX2_PAGE_POOL_MAX_SZ) And someone needs to tell me why the 2k was chosen as a value that uniquely fits this device but not other devices..
> From: Jakub Kicinski <kuba@kernel.org> > Sent: Thursday, August 10, 2023 11:30 PM > To: Alexander Lobakin <aleksander.lobakin@intel.com> > > min(numptrs, OTX2_PAGE_POOL_MAX_SZ) > > And someone needs to tell me why the 2k was chosen as a value that > uniquely fits this device but not other devices.. Would i move this macro ( min(numptrs, PAGE_POOL_MAX_SZ) ) to page_pool_init() ? -Ratheesh
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c index 77c8f650f7ac..123348a9e19e 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c @@ -1432,7 +1432,8 @@ int otx2_pool_init(struct otx2_nic *pfvf, u16 pool_id, } pp_params.flags = PP_FLAG_PAGE_FRAG | PP_FLAG_DMA_MAP; - pp_params.pool_size = numptrs; +#define OTX2_PAGE_POOL_SZ 2048 + pp_params.pool_size = OTX2_PAGE_POOL_SZ; pp_params.nid = NUMA_NO_NODE; pp_params.dev = pfvf->dev; pp_params.dma_dir = DMA_FROM_DEVICE;
page pool infra does direct recycling aggressively. This would often keep ptr_ring left unused. Save memory by configuring ptr_ring to a constant value(2K). Please find discussion at https://lore.kernel.org/netdev/ 15d32b22-22b0-64e3-a49e-88d780c24616@kernel.org/T/ Fixes: b2e3406a38f0 ("octeontx2-pf: Add support for page pool") Suggested-by: Alexander Lobakin <aleksander.lobakin@intel.com> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com> --- drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)