| Message ID | 20230810144451.1459985-5-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | imx6q related DT binding fixes | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Thu, 10 Aug 2023 16:44:49 +0200, Alexander Stein wrote: > MAC address can be provided by a nvmem-cell, thus allow referencing a > source for the address. Fixes the warning: > arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: ethernet@1: 'nvmem-cell-names', > 'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+' > From schema: Documentation/devicetree/bindings/net/microchip,lan95xx.yaml > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > Documentation/devicetree/bindings/net/microchip,lan95xx.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
Am Montag, 21. August 2023, 19:14:39 CEST schrieb Rob Herring: > On Thu, 10 Aug 2023 16:44:49 +0200, Alexander Stein wrote: > > MAC address can be provided by a nvmem-cell, thus allow referencing a > > source for the address. Fixes the warning: > > arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: ethernet@1: 'nvmem-cell-names', > > > > 'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+' > > From schema: Documentation/devicetree/bindings/net/microchip,lan95xx.yaml > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > > > Documentation/devicetree/bindings/net/microchip,lan95xx.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > Reviewed-by: Rob Herring <robh@kernel.org> Thanks. But while reading your comment on patch 3, I'm wondering if additionalProperties should be changed to unevaluatedProperties here as well. This way local-mac-address and mac-address canbe removed as well, they are defined in ethernet-controller.yaml already. Best regards, Alexander
diff --git a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml index 0b97e14d947f..247e7707181c 100644 --- a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml +++ b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml @@ -44,6 +44,8 @@ properties: local-mac-address: true mac-address: true + nvmem-cells: true + nvmem-cell-names: true required: - compatible
MAC address can be provided by a nvmem-cell, thus allow referencing a source for the address. Fixes the warning: arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: ethernet@1: 'nvmem-cell-names', 'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: Documentation/devicetree/bindings/net/microchip,lan95xx.yaml Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- Documentation/devicetree/bindings/net/microchip,lan95xx.yaml | 2 ++ 1 file changed, 2 insertions(+)