| Message ID | 20230810150328.19704-2-rohan.g.thomas@intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Tx coe sw fallback for unsupported queues | expand |
On Thu, Aug 10, 2023 at 11:03:27PM +0800, Rohan G Thomas wrote: > Add dt-bindings for the number of tx queues with coe support. Some > dwmac IPs support tx queues only for few initial tx queues, starting > from tx queue 0. > > Signed-off-by: Rohan G Thomas <rohan.g.thomas@intel.com> > --- > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index ddf9522a5dc2..ad26a32e0557 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -313,6 +313,9 @@ properties: > snps,tx-queues-to-use: > $ref: /schemas/types.yaml#/definitions/uint32 > description: number of TX queues to be used in the driver > + snps,tx-queues-with-coe: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: number of TX queues support TX checksum offloading Either you omitted a "ing" or a whole word from this description. > snps,tx-sched-wrr: > type: boolean > description: Weighted Round Robin > -- > 2.26.2 >
Dear Conor, On Thu, Aug 10, 2023 at 11:03:27PM +0800, Rohan G Thomas wrote: > > Add dt-bindings for the number of tx queues with coe support. Some > > dwmac IPs support tx queues only for few initial tx queues, starting > > from tx queue 0. > > > > Signed-off-by: Rohan G Thomas <rohan.g.thomas@intel.com> > > --- > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > index ddf9522a5dc2..ad26a32e0557 100644 > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > @@ -313,6 +313,9 @@ properties: > > snps,tx-queues-to-use: > > $ref: /schemas/types.yaml#/definitions/uint32 > > description: number of TX queues to be used in the driver > > + snps,tx-queues-with-coe: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: number of TX queues support TX checksum > > + offloading > > Either you omitted a "ing" or a whole word from this description. Thanks for pointing this out. Will fix it in the next version as below, description: number of TX queues that supports TX checksum offloading > > > snps,tx-sched-wrr: > > type: boolean > > description: Weighted Round Robin > > -- > > 2.26.2 > > Best Regards, Rohan
On 10/08/2023 17:03, Rohan G Thomas wrote: > Add dt-bindings for the number of tx queues with coe support. Some > dwmac IPs support tx queues only for few initial tx queues, starting > from tx queue 0. > > Signed-off-by: Rohan G Thomas <rohan.g.thomas@intel.com> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least DT list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index ddf9522a5dc2..ad26a32e0557 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -313,6 +313,9 @@ properties: snps,tx-queues-to-use: $ref: /schemas/types.yaml#/definitions/uint32 description: number of TX queues to be used in the driver + snps,tx-queues-with-coe: + $ref: /schemas/types.yaml#/definitions/uint32 + description: number of TX queues support TX checksum offloading snps,tx-sched-wrr: type: boolean description: Weighted Round Robin
Add dt-bindings for the number of tx queues with coe support. Some dwmac IPs support tx queues only for few initial tx queues, starting from tx queue 0. Signed-off-by: Rohan G Thomas <rohan.g.thomas@intel.com> --- Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++ 1 file changed, 3 insertions(+)