diff mbox series

[iproute2-next] devlink: spell out STATE in devlink port function help

Message ID 20230814072901.1865650-1-jiri@resnulli.us (mailing list archive)
State Accepted
Commit 872148f54e35cb13aa6c9e48e52306cd469aaa53
Delegated to: Stephen Hemminger
Headers show
Series [iproute2-next] devlink: spell out STATE in devlink port function help | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Jiri Pirko Aug. 14, 2023, 7:29 a.m. UTC 
From: Jiri Pirko <jiri@nvidia.com>

Be in-sync with port help and port man page and spell out the possible
states instead of "STATE".

Signed-off-by: Jiri Pirko <jiri@nvidia.com>
---
 devlink/devlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org Aug. 19, 2023, 4:22 p.m. UTC | #1 
Hello:

This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:

On Mon, 14 Aug 2023 09:29:01 +0200 you wrote:
> From: Jiri Pirko <jiri@nvidia.com>
> 
> Be in-sync with port help and port man page and spell out the possible
> states instead of "STATE".
> 
> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
> 
> [...]

Here is the summary with links:
  - [iproute2-next] devlink: spell out STATE in devlink port function help
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=872148f54e35

You are awesome, thank you!
diff mbox series

Patch

diff --git a/devlink/devlink.c b/devlink/devlink.c
index 3cb102736b19..1a522111385b 100644
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
@@ -4962,7 +4962,7 @@  static int cmd_port_param_show(struct dl *dl)
 
 static void cmd_port_function_help(void)
 {
-	pr_err("Usage: devlink port function set DEV/PORT_INDEX [ hw_addr ADDR ] [ state STATE ]\n");
+	pr_err("Usage: devlink port function set DEV/PORT_INDEX [ hw_addr ADDR ] [ state { active | inactive } ]\n");
 	pr_err("                      [ roce { enable | disable } ] [ migratable { enable | disable } ]\n");
 	pr_err("       devlink port function rate { help | show | add | del | set }\n");
 }