| Message ID | 20230818080613.1969817-1-liuhangbin@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c4cf2bc0d2c97214e41b44b2b05cedc7093ccbbd |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] selftests: vrf_route_leaking: remove ipv6_ping_frag from default testing | expand |
On 8/18/23 2:06 AM, Hangbin Liu wrote: > As the initial commit 1a01727676a8 ("selftests: Add VRF route leaking > tests") said, the IPv6 MTU test fails as source address selection > picking ::1. Every time we run the selftest this one report failed. > There seems not much meaning to keep reporting a failure for 3 years > that no one plan to fix/update. Let't just skip this one first. We can > add it back when the issue fixed. > > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> > --- > tools/testing/selftests/net/vrf_route_leaking.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/net/vrf_route_leaking.sh b/tools/testing/selftests/net/vrf_route_leaking.sh > index 23cf924754a5..dedc52562b4f 100755 > --- a/tools/testing/selftests/net/vrf_route_leaking.sh > +++ b/tools/testing/selftests/net/vrf_route_leaking.sh > @@ -565,7 +565,7 @@ EOF > command -v ping6 > /dev/null 2>&1 && ping6=$(command -v ping6) || ping6=$(command -v ping) > > TESTS_IPV4="ipv4_ping_ttl ipv4_traceroute ipv4_ping_frag ipv4_ping_ttl_asym ipv4_traceroute_asym" > -TESTS_IPV6="ipv6_ping_ttl ipv6_traceroute ipv6_ping_frag ipv6_ping_ttl_asym ipv6_traceroute_asym" > +TESTS_IPV6="ipv6_ping_ttl ipv6_traceroute ipv6_ping_ttl_asym ipv6_traceroute_asym" > > ret=0 > nsuccess=0 Needs to be fixed, but clearly not a high priority. I am ok with disabling the failed test: Reviewed-by: David Ahern <dsahern@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Fri, 18 Aug 2023 16:06:13 +0800 you wrote: > As the initial commit 1a01727676a8 ("selftests: Add VRF route leaking > tests") said, the IPv6 MTU test fails as source address selection > picking ::1. Every time we run the selftest this one report failed. > There seems not much meaning to keep reporting a failure for 3 years > that no one plan to fix/update. Let't just skip this one first. We can > add it back when the issue fixed. > > [...] Here is the summary with links: - [net-next] selftests: vrf_route_leaking: remove ipv6_ping_frag from default testing https://git.kernel.org/netdev/net-next/c/c4cf2bc0d2c9 You are awesome, thank you!
diff --git a/tools/testing/selftests/net/vrf_route_leaking.sh b/tools/testing/selftests/net/vrf_route_leaking.sh index 23cf924754a5..dedc52562b4f 100755 --- a/tools/testing/selftests/net/vrf_route_leaking.sh +++ b/tools/testing/selftests/net/vrf_route_leaking.sh @@ -565,7 +565,7 @@ EOF command -v ping6 > /dev/null 2>&1 && ping6=$(command -v ping6) || ping6=$(command -v ping) TESTS_IPV4="ipv4_ping_ttl ipv4_traceroute ipv4_ping_frag ipv4_ping_ttl_asym ipv4_traceroute_asym" -TESTS_IPV6="ipv6_ping_ttl ipv6_traceroute ipv6_ping_frag ipv6_ping_ttl_asym ipv6_traceroute_asym" +TESTS_IPV6="ipv6_ping_ttl ipv6_traceroute ipv6_ping_ttl_asym ipv6_traceroute_asym" ret=0 nsuccess=0
As the initial commit 1a01727676a8 ("selftests: Add VRF route leaking tests") said, the IPv6 MTU test fails as source address selection picking ::1. Every time we run the selftest this one report failed. There seems not much meaning to keep reporting a failure for 3 years that no one plan to fix/update. Let't just skip this one first. We can add it back when the issue fixed. Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> --- tools/testing/selftests/net/vrf_route_leaking.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)